Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: include a warning about generated files when generating files 💪 #33

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

robertrossmann
Copy link
Member

Description

I recently landed myself in an id_gen.go file using IDE's Go To Definition and started making updates, not noticing that it was a generated file.

This preamble would probably not help me because the file was long but perhaps it will help someone else. 🤷‍♂️

Type of change

Delete options that are not relevant.

  • Bug fix.
  • New feature.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Documentation update.

How has this been tested

  • In God We Trust

Checklist:

  • Pull request is linked with the corresponding issue.
  • Code follows the style guidelines of this project.
  • Change is documented in CHANGELOG.md.
  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation (README.md, openapi.yaml).
  • I have added tests that prove my fix is effective or that my feature works.
  • Unit tests pass with my changes.

@strvcom/go

I recently landed myself in an `id_gen.go` file using IDE's Go To Definition and started making updates, not noticing that it was a generated file.

This preamble would probably not help me because the file was long but perhaps it will help someone else. 🤷‍♂️
@robertrossmann robertrossmann requested a review from a team November 4, 2023 18:21
@robertrossmann robertrossmann self-assigned this Nov 4, 2023
@robertrossmann robertrossmann added the enhancement New feature or request label Nov 4, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2023

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 46.22%. Comparing base (f47a1fb) to head (591ed8d).
Report is 1 commits behind head on master.

Files Patch % Lines
cmd/tea/gen_id.go 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
- Coverage   46.84%   46.22%   -0.63%     
==========================================
  Files           5        5              
  Lines         222      225       +3     
==========================================
  Hits          104      104              
- Misses         95       97       +2     
- Partials       23       24       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Fazt01 Fazt01 merged commit 23eea15 into master Aug 16, 2024
2 of 3 checks passed
@Fazt01 Fazt01 deleted the feat/gen_id/preamble branch August 16, 2024 11:39
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants