-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(http): make ResponseWriter public #37
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Marek Cermak <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #37 +/- ##
=======================================
Coverage 64.08% 64.08%
=======================================
Files 12 12
Lines 646 646
=======================================
Hits 414 414
Misses 221 221
Partials 11 11 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, add corresponding changes to CHANGELOG.
Signed-off-by: Marek Cermak <[email protected]>
765b724
@bafko updated 👍 Thanks for the reminder. |
ResponseWriter
is an important structure accessed by the middleware and used indirectly by the signature package. If we expose it, it's possible to build custom middleware on top of our existing ones, reusing the data stored in the ResponseWriter.