Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

Update helpers.js #58

Closed
wants to merge 1 commit into from
Closed

Update helpers.js #58

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions lib/helpers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,9 @@ _beforeEach.cleanDatasource = function(dsName) {
if (typeof this.app === 'function'
&& typeof this.app.datasources === 'object'
&& typeof this.app.datasources[dsName] === 'object') {
this.app.datasources[dsName].automigrate();
this.app.datasources[dsName].automigrate(done);
this.app.datasources[dsName].connector.ids = {};
}

done();
});
}
Copy link
Contributor

@bajtos bajtos Jul 2, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should still call done in the case when the condition on lines 33-35 is false, otherwise the callback is never called.

Other than that, this looks good to me.


Expand Down