Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin pip to 18.x #559

Merged
merged 1 commit into from
Apr 24, 2019
Merged

Pin pip to 18.x #559

merged 1 commit into from
Apr 24, 2019

Conversation

ob-stripe
Copy link
Contributor

r? @brandur-stripe
cc @remi-stripe

Temporary workaround to make the builds green again.

The issue is caused by a combination of unfortunate factors:

For now, we can just downgrade pip to 18.x to avoid the issue.

Mid/long term, we should probably:

  • fully replace setup.py with pyproject.toml
  • get rid of pipenv

Copy link
Contributor

@brandur-stripe brandur-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

  • fully replace setup.py with pyproject.toml
  • get rid of pipenv

+1.

@ob-stripe ob-stripe merged commit 9c115d6 into master Apr 24, 2019
@ob-stripe ob-stripe deleted the ob-DX-3863 branch April 24, 2019 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants