Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from black to ruff for formatting #1329

Merged
merged 5 commits into from
May 13, 2024
Merged

Conversation

xavdid-stripe
Copy link
Member

Per discussion, I've swapped from black to ruff for formatting. It's must faster when running make codegen-format:

Before:

558 files reformatted, 104 files left unchanged.
  fmt: OK (13.54=setup[0.05]+cmd[13.48] seconds)
  congratulations :) (13.61 seconds)

after:

474 files reformatted, 188 files left unchanged
  fmt: OK (0.40=setup[0.04]+cmd[0.35] seconds)
  congratulations :) (0.44 seconds)

I separated the PR into 3 main commits:

  • tooling changes happened in 9b43579
  • mass formatting happened in c46b4b9
  • add a rev ignore file in 15c3956 (so I don't get credit for a ton of git-blame lines)

So broadly, a reviewer will mostly want to look at the changes from the first commit. Past that, there are superficial formatting changes, but nothing serious.

@xavdid-stripe xavdid-stripe requested review from a team and prathmesh-stripe and removed request for a team May 11, 2024 02:28
Copy link
Contributor

@prathmesh-stripe prathmesh-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! Thanks for listing out the separate commits.

@xavdid-stripe xavdid-stripe merged commit 46edbe3 into master May 13, 2024
15 checks passed
@xavdid-stripe xavdid-stripe deleted the black-to-ruff branch May 13, 2024 15:32
@stripe stripe deleted a comment from armandRobled Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants