Add OAuthService #964
Merged
Add OAuthService #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardm-stripe
force-pushed
the
richardm-add-oauth-service
branch
3 times, most recently
from
aa89bfd to
1e70240
Compare
ob-stripe
suggested changes
Jun 30, 2020
richardm-stripe
force-pushed
the
richardm-add-oauth-service
branch
from
d48c5f2 to
11c7a38
Compare
|
ptal @ob-stripe -- I've addressed all your comments & moved 'connectRequest' out into OAuthService. Thanks for the careful review. |
ob-stripe
suggested changes
Jul 1, 2020
richardm-stripe
force-pushed
the
richardm-add-oauth-service
branch
from
8eb8095 to
5305de9
Compare
|
ptal @ob-stripe
|
ob-stripe
suggested changes
Jul 2, 2020
lib/Service/OAuthService.php
Outdated
| // Throw an exception for the convenience of anybody migrating to | ||
| // \Stripe\Service\OAuthService from \Stripe\OAuth, where `connect_base` | ||
| // was the name of the parameter that behaves as `api_base` does here. | ||
| if (isset($opts->connect_base)) { |
There was a problem hiding this comment.
I'm not sure this will work. \Stripe\RequestOptions does not have a connect_base property, even if there is a connect_base key in the array passed to RequestOptions::parse(), so I think this condition will always be false. Mind adding a test for it?
There was a problem hiding this comment.
Oops! Good catch. Fixed now.
|
ptal @ob-stripe fixed the $opts['connect_base'] check and added docblocks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @ob-stripe
cc @stripe/api-libraries
Fixes #958 and adds
$stripe->oauthwithauthorizeUrl,token, anddeauthorizemethods.I chose to introduce
->requestConnectinto the StripeClientInterface, rather than overload->request, because to my intuition this seems cleaner, but I'm interested in second opinions.