Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pull request template #1797

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Added pull request template #1797

merged 1 commit into from
Dec 19, 2024

Conversation

jar-stripe
Copy link
Contributor

Why?

Capturing context enables us to leave a stronger paper trail for changes to our SDKs. This light template gives guidance on the type of context that is most relevant to capture.

What?

  • added pull_request_template.md to .github folder

@jar-stripe jar-stripe requested review from a team and prathmesh-stripe and removed request for a team December 19, 2024 00:43
@jar-stripe jar-stripe merged commit d89ed48 into master Dec 19, 2024
22 checks passed
@jar-stripe jar-stripe deleted the jar/pull-request-template branch December 19, 2024 00:47
xavdid-stripe pushed a commit that referenced this pull request Jan 9, 2025
* Update generated code (#1793)

* Update generated code for v1399

* Update generated code for v1409

* Update generated code for v1412

---------

Co-authored-by: Stripe OpenAPI <105521251+stripe-openapi[bot]@users.noreply.github.com>

* Bump version to 16.4.0

* Added pull request template (#1797)

* Update generated code for v1423

* Update generated code for v1424

* Update generated code for v1427

* Update generated code for v1429

* Update generated code for v1431

* Update generated code for v1433

* Update generated code for v1434

* Update generated code for v1436

* Update generated code for v1437

---------

Co-authored-by: stripe-openapi[bot] <105521251+stripe-openapi[bot]@users.noreply.github.com>
Co-authored-by: Jesse Rosalia <[email protected]>
prathmesh-stripe pushed a commit that referenced this pull request Jan 23, 2025
* Update generated code (#1793)

* Update generated code for v1399

* Update generated code for v1409

* Update generated code for v1412

---------

Co-authored-by: Stripe OpenAPI <105521251+stripe-openapi[bot]@users.noreply.github.com>

* Bump version to 16.4.0

* Added pull request template (#1797)

* Add justfile, remove coveralls, and fix AUTOLOAD in CI (#1801)

* add justfile and tweak CI + readme

* debug test

* Debugging

* further debugging

* restore original composer json

* add more logging

* maybe fix ci

* Fix typo

* fix test naming and pass autoload directly to recipe as arugment

* Remove unused logline and fix typo

* restore composer

* remove extra log line

* update justfile

* add comments

* update ci

* revert to gh action

* ensure dependencies are installed for format and test recipes (#1802)

* Update generated code for v1439

* Update generated code for v1441

* Update generated code for v1441

* Update generated code for v1442

* Update generated code for v1443

* Update generated code for v1445

* Update generated code for v1446

* Update generated code for v1448

* Update generated code for v1449

* Update generated code for v1450

* Added CONTRIBUTING.md file (#1806)

* minor justfile fixes (#1807)

* made v2 event class concrete, and changed convertToStripeObject to use it if we cannot find the identified event subclass (#1805)

* Update generated code for v1454

* added CONTRIBUTING.md

* Update generated code for v1456

* Update generated code for v1457

* Update generated code for v1460

---------

Co-authored-by: stripe-openapi[bot] <105521251+stripe-openapi[bot]@users.noreply.github.com>
Co-authored-by: Jesse Rosalia <[email protected]>
Co-authored-by: David Brownman <[email protected]>
xavdid-stripe added a commit that referenced this pull request Feb 7, 2025
* Update generated code (#1793)

* Update generated code for v1399

* Update generated code for v1409

* Update generated code for v1412

---------

Co-authored-by: Stripe OpenAPI <105521251+stripe-openapi[bot]@users.noreply.github.com>

* Bump version to 16.4.0

* Added pull request template (#1797)

* Add justfile, remove coveralls, and fix AUTOLOAD in CI (#1801)

* add justfile and tweak CI + readme

* debug test

* Debugging

* further debugging

* restore original composer json

* add more logging

* maybe fix ci

* Fix typo

* fix test naming and pass autoload directly to recipe as arugment

* Remove unused logline and fix typo

* restore composer

* remove extra log line

* update justfile

* add comments

* update ci

* revert to gh action

* ensure dependencies are installed for format and test recipes (#1802)

* Added CONTRIBUTING.md file (#1806)

* minor justfile fixes (#1807)

* made v2 event class concrete, and changed convertToStripeObject to use it if we cannot find the identified event subclass (#1805)

* Update generated code for v1461

* Update generated code (#1804)

* Update generated code for v1441

* Update generated code for v1452

* Update generated code for v1455

---------

Co-authored-by: Stripe OpenAPI <105521251+stripe-openapi[bot]@users.noreply.github.com>
Co-authored-by: helenye-stripe <[email protected]>

* Bump version to 16.5.0

* Make `httpClient()` a public, static method (#1810)

* Make `httpClient()` a public, static method

* Make `streamingHttpClient()` a public, static method

* Update generated code for v1467

* Raise a more descriptive error if null bytes are found in the path (#1811)

* raise a more descriptive error if null bytes are found in the path

* formatting

* change error thrown for null byte issues (#1813)

* Update generated code for v1472

---------

Co-authored-by: stripe-openapi[bot] <105521251+stripe-openapi[bot]@users.noreply.github.com>
Co-authored-by: Jesse Rosalia <[email protected]>
Co-authored-by: David Brownman <[email protected]>
Co-authored-by: helenye-stripe <[email protected]>
Co-authored-by: Helen Ye <[email protected]>
Co-authored-by: Johan de Jager <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants