Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document but discourage protocol config option #940

Merged
merged 1 commit into from
Jul 1, 2020

Conversation

richardm-stripe
Copy link
Contributor

@richardm-stripe richardm-stripe commented Jul 1, 2020

r? @ob-stripe
cc @stripe/api-libraries
Throws an exception when the stripe client is initialized if the http protocol is specified without configuring a non-stripe.com host.
Also documents the protocol configuration option.
Fixes #938

@richardm-stripe richardm-stripe force-pushed the richardm-document-https-with-warning branch from 84a5e5e to bcb3660 Compare July 1, 2020 18:57
Copy link
Contributor

@ob-stripe ob-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@richardm-stripe richardm-stripe merged commit ff9c5b7 into master Jul 1, 2020
@richardm-stripe richardm-stripe deleted the richardm-document-https-with-warning branch July 1, 2020 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants