Multiple API changes #883
Merged
Multiple API changes #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-stripe
commented
May 1, 2020
| /** | ||
| * ID of the price to which the customer should be subscribed. | ||
| */ | ||
| price?: string | Stripe.Price | Stripe.DeletedPrice; |
There was a problem hiding this comment.
Yes this is expected. It wasn't in node because we merged before we finished the change we put in Java here https://github.com/stripe/stripe-java/blob/master/src/main/java/com/stripe/model/SubscriptionSchedule.java#L730-L734
ob-stripe
approved these changes
May 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple API changes
issuingonBalancebr_cnpjandbr_cpfastypeonTaxIdpricesupport in phases onSubscriptionSchedulequantitynullable onSubscriptionSchedulefor upcoming API version changeCodegen for openapi db4b68c
r? @ob-stripe
cc @stripe/api-libraries