Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate export #728

Merged
merged 1 commit into from
Nov 22, 2019
Merged

Conversation

esetnik
Copy link
Contributor

@esetnik esetnik commented Nov 18, 2019

Fixes #727

Copy link
Contributor

@rattrayalex-stripe rattrayalex-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

Looks like a typo, not sure how that happened.

@rattrayalex-stripe rattrayalex-stripe merged commit d8b7edc into stripe:master Nov 22, 2019
nsallerin added a commit to fewlines-education/stripe-demo that referenced this pull request Dec 16, 2019
…ode-dependencies

## Description

**react** and **react-dom** updated from **16.9.0 to 16.12.0**

###### React DOM

* Remove `unstable_createRoot` and `unstable_createSyncRoot` experimental APIs. (These are available in the Experimental channel as `createRoot` and `createSyncRoot`.) ([@acdlite]
* Clear additional fiber fields during unmount to save memory. ([@trueadm](https://github.com/trueadm) in [#16807](facebook/react#16807))
* Prefer `Object.is` instead of inline polyfill, when available. ([@ku8ar](https://github.com/ku8ar) in [#16212](facebook/react#16212))

**react-scripts** updated from **16.9.0 to 16.12.0**

https://github.com/facebook/create-react-app/blob/master/CHANGELOG.md

**dotenv** updated from **8.1.0 to 8.2.0**

https://github.com/motdotla/dotenv/blob/master/CHANGELOG.md
---> no changes in changelog

**stripe** updated from **7.9.1 to 7.14.0**

- [#699](stripe/stripe-node#699) Add request-specific fields from raw error to top level error
- [#719](stripe/stripe-node#719) Define 'type' as a property on errors rather than a getter
- [#728](stripe/stripe-node#728) Remove duplicate export

## Related Issue

[ch1243]

## Motivation and Context

We want our dependencies up to date

## How Has This Been Tested?

Running `yarn test` all tests passed

## Types of changes

- Chore (non-breaking change which refactors / improves the existing code base)
- ~Bug fix (non-breaking change which fixes an issue)~
- ~New feature (non-breaking change which adds functionality)~
- ~Breaking change (fix or feature that would cause existing functionality to 
  change)~

## Checklist:

- ✅ My code follows the code style of this project.
- 🔴 My change requires a change to the documentation.
- 🔴 I have updated the documentation accordingly.
- ✅ I have read the [**CONTRIBUTING**][CONTRIBUTING_FILE] document.
- 🔴 I have added tests to cover my changes.
- ✅ All new and existing tests passed.

[CONTRIBUTING_FILE]: https://github.com/fewlinesco/connect/blob/master/CONTRIBUTING.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stripeMethod is exported twice
4 participants