Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor requestDataProcessor for File out into its own file #674

Merged
merged 1 commit into from
Aug 9, 2019

Conversation

rattrayalex-stripe
Copy link
Contributor

r? @richardm-stripe
cc @ob-stripe @stripe/api-libraries

This was in a codegen'd file, which lead to big/ugly diffs; we should ~never have substantial application logic in a codegen'd file.

While I was looking at the code, I refactored to make it a bit more simple/modern/unified.

Verified

This commit was signed with the committer’s verified signature.
ob-stripe Olivier Bellone
@richardm-stripe
Copy link
Contributor

richardm-stripe commented Aug 9, 2019

lgtm
Seems much better to me and, as far as I can reason, does the same thing. I'd be even more happy if there were a test.

@rattrayalex-stripe
Copy link
Contributor Author

FWIW there are some high-level integration tests in test/resources/Files.spec.js but that's certainly fair, coverage here is probably not what it should be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants