Remove empty resources created for service groupings #2215
Merged
+30
−81
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
The code generator had previously generated resources for V2 services that only contain other services, like V2.Billing, V2.Core, etc. This is undesirable because it produces strangely named files and confusing empty types. This PR updates contains generated code after modifying the code generator to treat these services like namespaces instead of resource-ful services.
This could be a breaking change as the CoreResource.d.ts and BillingResource.d.ts type definitions are being removed. The following therefore would be a type error after this change:
It does not change the access path through StripeClient or the interface of the services, though.
What?
See also
http://go/j/DEVSDK-2196
Changelog
Stripe.V2.BillingResource
,Stripe.V2.CoreResource
, andStripe.V2Resource
types from the public interface as they are no longer needed. SDK usage will not be affected but any references to these types in your application will need to be removed.