Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generateTestHeaderStringAsync function to Webhooks.ts #2048

Merged
merged 3 commits into from
Jul 8, 2024

Conversation

zelief
Copy link
Contributor

@zelief zelief commented Mar 22, 2024

Currently, generateTestHeaderString throws a CryptoProviderOnlySupportsAsyncError when executed in Bun and other non-Node environments. This presents a limitation for users attempting to utilize this function outside of Node.js.

This PR addresses this issue by adding generateTestHeaderStringAsync. With this, creating a test header string in non-Node environments becomes more seamless and straightforward.

@CLAassistant
Copy link

CLAassistant commented Mar 22, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ramya-stripe
Copy link
Contributor

Hey @zelief

There is some duplicated code between generateTestHeaderString and generateTestHeaderStringAsync. Can you consider sharing code between the two to ensure they dont diverge in the future?

Copy link
Contributor

@helenye-stripe helenye-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above comment.

@zelief
Copy link
Contributor Author

zelief commented Jul 6, 2024

Hey @zelief

There is some duplicated code between generateTestHeaderString and generateTestHeaderStringAsync. Can you consider sharing code between the two to ensure they dont diverge in the future?

Sure @ramya-stripe, I will update it. Thanks for the review!

@zelief
Copy link
Contributor Author

zelief commented Jul 6, 2024

Updated @ramya-stripe, kindly check.

Copy link
Member

@xavdid-stripe xavdid-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@xavdid-stripe xavdid-stripe requested review from helenye-stripe and removed request for helenye-stripe July 8, 2024 17:37
@xavdid-stripe xavdid-stripe dismissed helenye-stripe’s stale review July 8, 2024 17:38

fixes have been applied

@xavdid-stripe xavdid-stripe merged commit 3908aca into stripe:master Jul 8, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants