-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add generateTestHeaderStringAsync function to Webhooks.ts #2048
Conversation
|
Hey @zelief There is some duplicated code between |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above comment.
Sure @ramya-stripe, I will update it. Thanks for the review! |
Updated @ramya-stripe, kindly check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you!
Currently,
generateTestHeaderString
throws aCryptoProviderOnlySupportsAsyncError
when executed in Bun and other non-Node environments. This presents a limitation for users attempting to utilize this function outside of Node.js.This PR addresses this issue by adding
generateTestHeaderStringAsync
. With this, creating a test header string in non-Node environments becomes more seamless and straightforward.