Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Updates #1265

Merged
merged 1 commit into from
Oct 7, 2021
Merged

API Updates #1265

merged 1 commit into from
Oct 7, 2021

Conversation

richardm-stripe
Copy link
Contributor

Codegen for openapi d0904af.
r? @dcr-stripe
cc @stripe/api-libraries

Changelog

  • Add support for phone_number_collection on CheckoutSessionCreateParams and Checkout.Session
  • Add support for phone on Checkout.Session.customer_details
  • Change PaymentMethodListParams.customer to be optional
  • Add support for new value customer_id on enums RadarValueListCreateParams.item_type and Radar.ValueList.item_type
  • Add support for new value bbpos_wisepos_e on enums TerminalReaderListParams.device_type and Terminal.Reader.device_type

dcr-stripe
dcr-stripe reviewed Oct 7, 2021
View reviewed changes
Copy link
Contributor

@dcr-stripe dcr-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but something seems to be up with how we're basing off of master.

PTAL @richardm-stripe ?

types/2020-08-27/Accounts.d.ts Outdated
/**
* The status of the Klarna payments capability of the account, or whether the account can directly process Klarna charges.
*/
klarna_payments?: Capabilities.KlarnaPayments;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this is showing up in the diff - https://github.com/stripe/stripe-node/blob/1d484b23/types/2020-08-27/Accounts.d.ts#L237 this is already committed in master?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for https://github.com/stripe/stripe-node/blob/1d484b23/test/resources/generated_examples_test.spec.js#L1 actually.

@richardm-stripe
Copy link
Contributor Author

@dcr-stripe rebased and fixed

dcr-stripe
dcr-stripe approved these changes Oct 7, 2021
View reviewed changes
Copy link
Contributor

@dcr-stripe dcr-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@richardm-stripe richardm-stripe merged commit 330e86b into master Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcr-stripe dcr-stripe dcr-stripe approved these changes

Assignees

@richardm-stripe richardm-stripe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richardm-stripe @dcr-stripe