More idiomatic types #1018
Merged
More idiomatic types #1018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why travis is misbehaving but this change is innocuous and |
|
Is it possible to kick travis to retry? |
|
I've tried twice, no luck. Pretty sure I've seen this sort of error before "remote connection hung up" and its been transient. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes `FileLinkUpdateParams.expires_at^ to be "nullable" rather than "emptyStringable".
stripe-node converts nulls to empty strings before sending over the wire (urlencoded has no concept of 'null'), and using null is a more idiomatic way of "unsetting" a property so our convention for these type bindings is to provide null instead of empty string, but up till now our codegen infrastructure wasn't property handling this case before since it got confused by the presence of "now".
r? @ctrudeau-stripe
cc @stripe/api-libraries