Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sharing overrides and non-resource root models #1455

Conversation

pakrym-stripe
Copy link
Contributor

@pakrym-stripe pakrym-stripe commented Oct 11, 2022

Changelog:

Moved classes that were mistakenly generated at root level instead of being inlined into resources:

  • Inlined AutomaticPaymentMethodsPaymentIntent class to PaymentIntent.AutomaticPaymentMethods inner class
  • Inlined CreditedItems class to InvoiceLineItem.CreditedItems inner class
  • Inlined EventData class to Event.Data inner class
  • Inlined EventRequest class to Event.Request inner class
  • Inlined InvoiceLineItemPeriod class to InvoiceItem.Period inner class
  • Inlined PackageDimensions class to Sku.PackageDimensions and Product.PackageDimensions inner classeses.`
  • Inlined ProrationDetails class to InvoiceLineItem.ProrationDetails inner class
  • Inlined radar.Rule class to Charge.Rule inner class
  • Inlined treasury.FlowDetails class to TransactionEntry.FlowDetails inner class
  • Deleted StripeErrorResponse class that was unused.

Adjusted classes to follow naming and nesting rules:

  • Moved Account.DeclineChargeOn to Account.SettingsCardPayments.DeclineChargeOn
  • Moved Account.PayoutSchedule to Account.SettingsPayouts.PayoutSchedule
  • Moved Account.SettingsBranding to Account.Settings.Branding
  • Moved Account.SettingsCardPayments to Account.Settings.CardPayments
  • Moved Account.SettingsDashboard to Account.Settings.Dashboard
  • Moved Account.SettingsPayments to Account.Settings.Payments
  • Moved Account.SettingsPayouts to Account.Settings.Payouts
  • Moved Charge.PaymentMethodDetails.Store to Charge.PaymentMethodDetails.Konbini.Store
  • Moved Invoice.PaymentMethodOptions to Invoice.PaymentSettings.PaymentMethodOptions
  • Moved Invoice.ThresholdItemReason to Invoice.ThresholdReason.ItemReason
  • Moved Mandate.AuBecsDebit to Mandate.PaymentMethodDetails.AuBecsDebit
  • Moved Mandate.BacsDebit to Mandate.PaymentMethodDetails.BacsDebit
  • Moved PaymentIntent.PaymentMethodOptions.BlikMandateOptionsOffSessionDetails to Mandate.PaymentMethodDetails.Blik.OffSession
  • Moved PaymentIntent.PaymentMethodOptions.BankTransfer to PaymentIntent.PaymentMethodOptions.CustomerBalance.BankTransfer
  • Moved PaymentIntent.NextActionAlipayHandleRedirect to PaymentIntent.NextAction.AlipayHandleRedirect
  • Moved PaymentIntent.NextActionCardAwaitNotification to PaymentIntent.NextAction.CardAwaitNotification
  • Moved PaymentIntent.NextActionDisplayBankTransferInstructions to PaymentIntent.NextAction.DisplayBankTransferInstructions
  • Moved PaymentIntent.NextActionDisplayBoletoDetails to PaymentIntent.NextAction.BoletoDisplayDetails
  • Moved PaymentIntent.NextActionKonbiniDisplayDetails to PaymentIntent.NextAction.KonbiniDisplayDetails
  • Moved PaymentIntent.NextActionOxxoDisplayDetails to PaymentIntent.NextAction.OxxoDisplayDetails
  • Moved PaymentIntent.NextActionRedirectToUrl to PaymentIntent.NextAction.RedirectToUrl
  • Moved PaymentIntent.PaymentMethodOptions.SepaDebitMandateOptions to PaymentIntent.PaymentMethodOptions.SepaDebit.MandateOptions
  • Moved Person.VerificationDocument to Person.Verification.Document
  • Moved Person.VerificationDocument to Person.Verification.AdditionalDocument
  • Moved PromotionCode.CurrencyOption to PromotionCode.Restrictions.CurrencyOption
  • Moved Quote.Recurring to Quote.Computed.Recurring
  • Moved Quote.Upfront to Quote.Computed.Upfront
  • Moved Refund.NextActionDisplayDetails to Refund.NextAction.DisplayDetails
  • Moved SetupIntent.PaymentMethodOptions.BlikMandateOptions to SetupIntent.PaymentMethodOptions.Blik.MandateOptions
  • Moved SetupIntent.NextActionRedirectToUrl to SetupIntent.NextAction.RedirectToUrl
  • Moved SetupIntent.PaymentMethodOptions.SepaDebitMandateOptions to SetupIntent.PaymentMethodOptions.SepaDebit.MandateOptions
  • Moved ShippingRate.CurrencyOption to ShippingRate.FixedAmount.CurrencyOption
  • Moved Source.OrderItem to Source.Order.OrderItem
  • Moved Subscription.PaymentMethodOptions to Subscription.PaymentSettings.PaymentMethodOptions
  • Renamed Person.JapanAddress to Person.AddressKanji
  • Renamed Account.Company.Verification.VerificationDocument to Account.Company.Verification.Document
  • Moved SubscriptionSchedule.AddInvoiceItem to SubscriptionSchedule.Phase.AddInvoiceItem
  • Renamed Person.JapanAddress to Person.AddressKana
  • Moved SubscriptionSchedule.InvoiceSettings to SubscriptionSchedule.DefaultSettings.InvoiceSettings
  • Moved SubscriptionSchedule.PhaseItem to SubscriptionSchedule.Phase.Item
  • Renamed Account.FutureRequirements.Errors to Account.FutureRequirements.Error
  • Renamed Account.Requirements.Errors to Account.Requirements.Error
  • Renamed Account.Settings.SettingsCardIssuing to Account.Settings.CardIssuing
  • Renamed Account.Settings.SettingsTreasury to Account.Settings.Treasury
  • Renamed Balance.Money to Balance.Available
  • Renamed Balance.Money to Balance.ConnectReserved
  • Renamed Balance.Money to Balance.InstantAvailable
  • Renamed Balance.Details to Balance.Issuing
  • Renamed Balance.Money to Balance.Pending
  • Renamed BalanceTransaction.Fee to BalanceTransaction.FeeDetail
  • Renamed Capability.FutureRequirements.Errors to Capability.FutureRequirements.Error
  • Renamed CashBalance.BalanceSettings to CashBalance.Settings
  • Renamed Session.CustomerDetails.TaxID to Session.CustomerDetails.TaxId
  • Renamed Session.PaymentMethodOptions.GrabPay to Session.PaymentMethodOptions.Grabpay
  • Renamed Session.TaxIDCollection to Session.TaxIdCollection
  • Renamed CountrySpec.VerificationFields.Details to CountrySpec.VerificationFields.Company
  • Renamed CountrySpec.VerificationFields.Details to CountrySpec.VerificationFields.Individual
  • Renamed Account.Balance.CashBalance to Account.Balance.Cash
  • Renamed Account.Balance.CreditBalance to Account.Balance.Credit
  • Renamed VerificationReport.Document.DateOfBirth to VerificationReport.Document.Dob
  • Renamed VerificationReport.Document.DocumentCheckError to VerificationReport.Document.Error
  • Renamed VerificationReport.IdNumber.DateOfBirth to VerificationReport.IdNumber.Dob
  • Renamed VerificationReport.IdNumber.IdNumberCheckError to VerificationReport.IdNumber.Error
  • Renamed VerificationReport.Selfie.SelfieCheckError to VerificationReport.Selfie.Error
  • Renamed VerificationSession.VerifiedOutputs.DateOfBirth to VerificationSession.VerifiedOutputs.Dob
  • Renamed Invoice.DiscountAmount to Invoice.TotalDiscountAmount
  • Renamed Invoice.TaxAmount to Invoice.TotalTaxAmount
  • Renamed Cardholder.Individual.DateOfBirth to Cardholder.Individual.Dob
  • Renamed Transaction.PurchaseDetails.Flight.Segments to Transaction.PurchaseDetails.Flight.Segment
  • Renamed PaymentIntent.PaymentMethodOptions.Card.Installments.Plan to PaymentIntent.PaymentMethodOptions.Card.Installments.AvailablePlan
  • Renamed PaymentMethod.Klarna.DateOfBirth to PaymentMethod.Klarna.Dob
  • Renamed PaymentMethod.USBankAccount to PaymentMethod.UsBankAccount
  • Renamed Person.DateOfBirth to Person.Dob
  • Renamed Person.FutureRequirements.Errors to Person.FutureRequirements.Error
  • Renamed Review.Location to Review.IpAddressLocation
  • Renamed ScheduledQueryRun.RunError to ScheduledQueryRun.Error
  • Renamed Source.CodeVerificationFlow to Source.CodeVerification
  • Renamed Source.ReceiverFlow to Source.Receiver
  • Renamed Source.RedirectFlow to Source.Redirect
  • Renamed Source.Order to Source.SourceOrder
  • Renamed SourceMandateNotification.AcssDebitData to SourceMandateNotification.AcssDebit
  • Renamed SourceMandateNotification.BacsDebitData to SourceMandateNotification.BacsDebit
  • Renamed SourceMandateNotification.SepaDebitData to SourceMandateNotification.SepaDebit
  • Renamed SourceTransaction.AchCreditTransferData to SourceTransaction.AchCreditTransfer
  • Renamed SourceTransaction.ChfCreditTransferData to SourceTransaction.ChfCreditTransfer
  • Renamed SourceTransaction.GbpCreditTransferData to SourceTransaction.GbpCreditTransfer
  • Renamed SourceTransaction.PaperCheckData to SourceTransaction.PaperCheck
  • Renamed SourceTransaction.SepaCreditTransferData to SourceTransaction.SepaCreditTransfer
  • Renamed Reader.ReaderAction to Reader.Action
  • Renamed FinancialAccountFeatures.FinancialAddresses.Aba.StatusDetails to FinancialAccountFeatures.FinancialAddresses.Aba.StatusDetail
  • Renamed FinancialAccountFeatures.CardIssuing.StatusDetails to FinancialAccountFeatures.CardIssuing.StatusDetail
  • Renamed FinancialAccountFeatures.DepositInsurance.StatusDetails to FinancialAccountFeatures.DepositInsurance.StatusDetail
  • Renamed FinancialAccountFeatures.InboundTransfers.Ach.StatusDetails to FinancialAccountFeatures.InboundTransfers.Ach.StatusDetail
  • Renamed FinancialAccountFeatures.IntraStripeFlows.StatusDetails to FinancialAccountFeatures.IntraStripeFlows.StatusDetail
  • Renamed FinancialAccountFeatures.OutboundPayments.Ach.StatusDetails to FinancialAccountFeatures.OutboundPayments.Ach.StatusDetail
  • Renamed FinancialAccountFeatures.OutboundPayments.UsDomesticWire.StatusDetails to FinancialAccountFeatures.OutboundPayments.UsDomesticWire.StatusDetail
  • Renamed FinancialAccountFeatures.OutboundTransfers.Ach.StatusDetails to FinancialAccountFeatures.OutboundTransfers.Ach.StatusDetail
  • Renamed FinancialAccountFeatures.OutboundTransfers.UsDomesticWire.StatusDetails to FinancialAccountFeatures.OutboundTransfers.UsDomesticWire.StatusDetail

@pakrym-stripe pakrym-stripe changed the base branch from master to sdk-release/next-major October 11, 2022 16:18
@pakrym-stripe pakrym-stripe marked this pull request as ready for review October 12, 2022 22:07
@pakrym-stripe pakrym-stripe merged commit e59bfb6 into sdk-release/next-major Oct 12, 2022
@remi-stripe remi-stripe deleted the pakrym/Remove_sharing_overrides_and_non-resource_root_models branch September 28, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants