Add analytics to applepaycontext #4708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| additionalNonPIIParams: [ | ||
| "error_message": errorMessage, | ||
| ]) | ||
| self.analyticsClient.log(analytic: errorAnalytic, apiClient: self.apiClient) | ||
| handleFinalState(.error, intentCreationError) |
There was a problem hiding this comment.
What is handleFinalState? Can we make the analytics calls in there to consolidate?
There was a problem hiding this comment.
Thanks for the feedback! I was trying to get unique messages populated in the handleFinalState, but passing only the analytic seems to make the code cleaner.
|
After this merges should we add these events to https://trailhead.corp.stripe.com/docs/mobile-sdk/analytics-notes? |
porter-stripe
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add instrumentation to apple pay context by adding analytics
Motivation
Need analytics
Testing
Looking into writing mocked tests
Changelog