Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add promo badge for incentives in MPE #4285

Draft
wants to merge 3 commits into
base: tillh/mpe-promo-badge-ui
Choose a base branch
from

Conversation

tillh-stripe
Copy link
Collaborator

Summary

Motivation

Testing

Changelog

Copy link

github-actions bot commented Nov 20, 2024

🚨 New dead code detected in this PR:

PaymentMethodTypeCollectionView.swift:90 warning: Function 'setIncentive(_:)' is unused
PaymentMethodIncentive.swift:16 warning: Initializer 'init(identifier:text:)' is unused
VerticalPaymentMethodListViewController.swift:28 warning: Property 'incentive' is assigned, but never used

Please remove the dead code before merging.

If this is intentional, you can bypass this check by adding the label skip dead code check to this PR.

ℹ️ If this comment appears to be left in error, double check that the flagged code is actually used and/or make sure your branch is up-to-date with master.

@tillh-stripe tillh-stripe force-pushed the tillh/ibp-incentives-model-changes branch from e94fc93 to 39a1379 Compare November 20, 2024 12:44
@tillh-stripe tillh-stripe changed the title Add promo badge in horizontal and vertical mode Add promo badge for incentives in MPE Nov 20, 2024
Base automatically changed from tillh/ibp-incentives-model-changes to master November 20, 2024 16:06
Copy link

emerge-tools bot commented Nov 20, 2024

📸 Snapshot Test

No snapshots generated

Name Added Removed Modified Unchanged Errored Approval
StripeApplePaySize
com.stripe.StripeApplePaySize
0 0 0 0 0 N/A
StripePaymentSheetSize
com.stripe.StripePaymentSheetSize
0 0 0 0 0 N/A
StripeFinancialConnectionsSize
com.stripe.StripeFinancialConnectionsSize
0 0 0 0 0 N/A
StripeSize
com.stripe.StripeSize
0 0 0 0 0 N/A
StripePaymentsSize
com.stripe.StripePaymentsSize
0 0 0 0 0 N/A
StripePaymentsUISize
com.stripe.StripePaymentsUISize
0 0 0 0 0 N/A

🛸 Powered by Emerge Tools

@tillh-stripe tillh-stripe force-pushed the tillh/ibp-incentives-ui-changes branch 2 times, most recently from 91b5ab1 to a501ff1 Compare November 20, 2024 22:21
@tillh-stripe tillh-stripe changed the base branch from master to tillh/mpe-promo-badge-ui November 20, 2024 22:22
@tillh-stripe tillh-stripe force-pushed the tillh/ibp-incentives-ui-changes branch 3 times, most recently from 48ea3bd to b0d3f24 Compare November 21, 2024 14:04
@tillh-stripe tillh-stripe force-pushed the tillh/mpe-promo-badge-ui branch 2 times, most recently from 4630b6f to a224fee Compare November 21, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant