New manage card screen with cbc update and remove #4251

joyceqin-stripe · 2024-11-13T00:30:45Z

Summary

New screen for managing payment methods. Only for card right now. Cbc update or remove
Builds on branch joyceqin-MOBILESDK-2661
Link to Figma: https://www.figma.com/design/ysEUcRWOfdEH4C0jBA0EkH/MPE-LPM-Visibility-%26-Vertical-Mode-Rollout?node-id=9266-174142&node-type=frame&t=6jEm7yaKldiNM3E9-0

Motivation

Sync default pms project
MOBILESDK-2662

Testing

Snapshot test

Changelog

github-actions · 2024-11-13T00:32:02Z

⚠️ Missing Translations
The following strings have been uploaded to Lokalise but are not yet translated.

Card details cannot be changed., Manage card

If it's okay for these strings to be unlocalized in master (e.g. this is for an unshipped feature), add the label ship without translations to acknowledge that there are missing translations. Otherwise, wait until translations are available in Lokalise and re-run this job.

New strings are localized on a weekly basis and are downloaded as part of the release process. For more details on how to localize a string, you can refer to this link.

emerge-tools · 2024-11-13T00:40:34Z

⚠️ 1 new unused protocol, 6 builds increased size

Name	Version	Download	Change	Install	Change	Approval
StripeSize com.stripe.StripeSize	1.0 (1)	2.1 MB	⬇️ 1.2 kB (-0.06%)	6.9 MB	⬆️ 7.2 kB (0.11%)	N/A
StripeApplePaySize com.stripe.StripeApplePaySize	1.0 (1)	449.0 kB	⬆️ 72 B (0.02%)	1.6 MB	⬆️ 144 B	N/A
StripeFinancialConnectionsSize com.stripe.StripeFinancialConnectionsSize	1.0 (1)	1.3 MB	⬆️ 1.8 kB (0.13%)	4.4 MB	⬆️ 5.3 kB (0.12%)	N/A
StripePaymentsSize com.stripe.StripePaymentsSize	1.0 (1)	1.2 MB	⬆️ 467 B (0.04%)	4.1 MB	⬆️ 144 B	N/A
StripePaymentsUISize com.stripe.StripePaymentsUISize	1.0 (1)	1.9 MB	⬆️ 4.0 kB (0.21%)	6.3 MB	⬆️ 6.8 kB (0.11%)	N/A
StripePaymentSheetSize com.stripe.StripePaymentSheetSize	1.0 (1)	3.7 MB	⬆️ 10.3 kB (0.28%)	10.9 MB	⬆️ 37.8 kB (0.35%)	N/A

StripeSize 1.0 (1)
com.stripe.StripeSize

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 7.2 kB (0.11%)
Total download size change: ⬇️ 1.2 kB (-0.06%)

Largest size changes

Item	Install Size Change
📝 StripePaymentsUI.DropdownFieldElement.itemsWithLabel(from,theme,i...	⬆️ 1.5 kB
StripeUICore.PickerFieldView.displayText.setter	⬆️ 1.1 kB
📝 StripePaymentsUI.DropdownFieldElement.makeCardBrandDropdownWithLa...	⬆️ 632 B
DYLD.Exports	⬆️ 552 B
StripePaymentsUI.DropdownFieldElement.items(from,theme,includePla...	⬇️ -552 B

View Treemap

StripeApplePaySize 1.0 (1)
com.stripe.StripeApplePaySize

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 144 B
Total download size change: ⬆️ 72 B (0.02%)

Largest size changes

Item	Install Size Change
Other	⬆️ 144 B

View Treemap

StripeFinancialConnectionsSize 1.0 (1)
com.stripe.StripeFinancialConnectionsSize

⚠️ Found new unused protocol: UpdatePaymentMethodViewControllerDelegate
⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 5.3 kB (0.12%)
Total download size change: ⬆️ 1.8 kB (0.13%)

Largest size changes

Item	Install Size Change
StripeUICore.PickerFieldView.displayText.setter	⬆️ 1.1 kB
Other	⬆️ 4.2 kB

View Treemap

StripePaymentsSize 1.0 (1)
com.stripe.StripePaymentsSize

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 144 B
Total download size change: ⬆️ 467 B (0.04%)

Largest size changes

Item	Install Size Change
Other	⬆️ 144 B

View Treemap

StripePaymentsUISize 1.0 (1)
com.stripe.StripePaymentsUISize

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 6.8 kB (0.11%)
Total download size change: ⬆️ 4.0 kB (0.21%)

Largest size changes

Item	Install Size Change
📝 StripePaymentsUI.DropdownFieldElement.itemsWithLabel(from,theme,i...	⬆️ 1.5 kB
StripeUICore.PickerFieldView.displayText.setter	⬆️ 1.1 kB
📝 StripePaymentsUI.DropdownFieldElement.makeCardBrandDropdownWithLa...	⬆️ 632 B
StripePaymentsUI.DropdownFieldElement.items(from,theme,includePla...	⬇️ -552 B
DYLD.Exports	⬆️ 528 B

View Treemap

StripePaymentSheetSize 1.0 (1)
com.stripe.StripePaymentSheetSize

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 37.8 kB (0.35%)
Total download size change: ⬆️ 10.3 kB (0.28%)

Largest size changes

Item	Install Size Change
📝 StripePaymentSheet.UpdatePaymentMethodViewController.cardBrandDro...	⬆️ 2.4 kB
📝 StripePaymentsUI.DropdownFieldElement.itemsWithLabel(from,theme,i...	⬆️ 1.5 kB
📝 StripePaymentSheet.UpdatePaymentMethodViewController.Objc Metadat...	⬆️ 1.4 kB
📝 StripePaymentSheet.UpdatePaymentMethodViewController.deleteButton	⬆️ 1.2 kB
StripeUICore.PickerFieldView.displayText.setter	⬆️ 1.1 kB

View Treemap

🛸 Powered by Emerge Tools

emerge-tools · 2024-11-13T00:40:34Z

⚠️ 1 new unused protocol, 6 builds increased size

Name	Version	Download	Change	Install	Change	Approval
StripeSize com.stripe.StripeSize	1.0 (1)	2.1 MB	⬇️ 1.2 kB (-0.06%)	6.9 MB	⬆️ 7.2 kB (0.11%)	N/A
StripeApplePaySize com.stripe.StripeApplePaySize	1.0 (1)	449.0 kB	⬆️ 72 B (0.02%)	1.6 MB	⬆️ 144 B	N/A
StripeFinancialConnectionsSize com.stripe.StripeFinancialConnectionsSize	1.0 (1)	1.3 MB	⬆️ 1.8 kB (0.13%)	4.4 MB	⬆️ 5.3 kB (0.12%)	N/A
StripePaymentsSize com.stripe.StripePaymentsSize	1.0 (1)	1.2 MB	⬆️ 467 B (0.04%)	4.1 MB	⬆️ 144 B	N/A
StripePaymentsUISize com.stripe.StripePaymentsUISize	1.0 (1)	1.9 MB	⬆️ 4.0 kB (0.21%)	6.3 MB	⬆️ 6.8 kB (0.11%)	N/A
StripePaymentSheetSize com.stripe.StripePaymentSheetSize	1.0 (1)	3.7 MB	⬆️ 10.3 kB (0.28%)	10.9 MB	⬆️ 37.8 kB (0.35%)	N/A

StripeSize 1.0 (1)
com.stripe.StripeSize

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 7.2 kB (0.11%)
Total download size change: ⬇️ 1.2 kB (-0.06%)

Largest size changes

Item	Install Size Change
📝 StripePaymentsUI.DropdownFieldElement.itemsWithLabel(from,theme,i...	⬆️ 1.5 kB
StripeUICore.PickerFieldView.displayText.setter	⬆️ 1.1 kB
📝 StripePaymentsUI.DropdownFieldElement.makeCardBrandDropdownWithLa...	⬆️ 632 B
DYLD.Exports	⬆️ 552 B
StripePaymentsUI.DropdownFieldElement.items(from,theme,includePla...	⬇️ -552 B

View Treemap

StripeApplePaySize 1.0 (1)
com.stripe.StripeApplePaySize

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 144 B
Total download size change: ⬆️ 72 B (0.02%)

Largest size changes

Item	Install Size Change
Other	⬆️ 144 B

View Treemap

StripeFinancialConnectionsSize 1.0 (1)
com.stripe.StripeFinancialConnectionsSize

⚠️ Found new unused protocol: UpdatePaymentMethodViewControllerDelegate
⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 5.3 kB (0.12%)
Total download size change: ⬆️ 1.8 kB (0.13%)

Largest size changes

Item	Install Size Change
StripeUICore.PickerFieldView.displayText.setter	⬆️ 1.1 kB
Other	⬆️ 4.2 kB

View Treemap

StripePaymentsSize 1.0 (1)
com.stripe.StripePaymentsSize

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 144 B
Total download size change: ⬆️ 467 B (0.04%)

Largest size changes

Item	Install Size Change
Other	⬆️ 144 B

View Treemap

StripePaymentsUISize 1.0 (1)
com.stripe.StripePaymentsUISize

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 6.8 kB (0.11%)
Total download size change: ⬆️ 4.0 kB (0.21%)

Largest size changes

Item	Install Size Change
📝 StripePaymentsUI.DropdownFieldElement.itemsWithLabel(from,theme,i...	⬆️ 1.5 kB
StripeUICore.PickerFieldView.displayText.setter	⬆️ 1.1 kB
📝 StripePaymentsUI.DropdownFieldElement.makeCardBrandDropdownWithLa...	⬆️ 632 B
StripePaymentsUI.DropdownFieldElement.items(from,theme,includePla...	⬇️ -552 B
DYLD.Exports	⬆️ 528 B

View Treemap

StripePaymentSheetSize 1.0 (1)
com.stripe.StripePaymentSheetSize

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 37.8 kB (0.35%)
Total download size change: ⬆️ 10.3 kB (0.28%)

Largest size changes

Item	Install Size Change
📝 StripePaymentSheet.UpdatePaymentMethodViewController.cardBrandDro...	⬆️ 2.4 kB
📝 StripePaymentsUI.DropdownFieldElement.itemsWithLabel(from,theme,i...	⬆️ 1.5 kB
📝 StripePaymentSheet.UpdatePaymentMethodViewController.Objc Metadat...	⬆️ 1.4 kB
📝 StripePaymentSheet.UpdatePaymentMethodViewController.deleteButton	⬆️ 1.2 kB
StripeUICore.PickerFieldView.displayText.setter	⬆️ 1.1 kB

View Treemap

🛸 Powered by Emerge Tools

github-actions · 2024-11-13T00:45:43Z

🚨 New dead code detected in this PR:

UpdatePaymentMethodViewController.swift:188 warning: Initializer 'init(paymentMethod:removeSavedPaymentMethodMessage:appearance:hostedSurface:canEditCard:canRemoveCard:isTestMode:cardBrandFilter:)' is unused
UpdatePaymentMethodViewController.swift:307 warning: Parameter 'sheetNavigationBar' is unused
STPCardBrand+PaymentsUI.swift:43 warning: Parameter 'maxWidth' is unused

Please remove the dead code before merging.

If this is intentional, you can bypass this check by adding the label skip dead code check to this PR.

ℹ️ If this comment appears to be left in error, double check that the flagged code is actually used and/or make sure your branch is up-to-date with master.

joyceqin-stripe added 15 commits November 12, 2024 10:04

remove-only screen

b60b94e

applied some changes

f0763d4

analytics

ae7d2c6

removed comment

c3eabb0

removed disabled background color and reenabled error

796f749

fix build?

6a84c97

button spacing

c74b872

Merge branch 'master' into joyceqin-MOBILESDK-2661

d19d119

cbc dropdown

9831569

removed reference to setDisabledBackgroundColor

8dd2c0d

revert

95997f1

valid card date

692d24c

update analytics;

2b78818

update analytics

e2b5677

merge;

30e87bf

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New manage card screen with cbc update and remove #4251

New manage card screen with cbc update and remove #4251

joyceqin-stripe commented Nov 13, 2024 •

edited

Loading

github-actions bot commented Nov 13, 2024

emerge-tools bot commented Nov 13, 2024

emerge-tools bot commented Nov 13, 2024

github-actions bot commented Nov 13, 2024

New manage card screen with cbc update and remove #4251

Are you sure you want to change the base?

New manage card screen with cbc update and remove #4251

Conversation

joyceqin-stripe commented Nov 13, 2024 • edited Loading

Summary

Motivation

Testing

Changelog

github-actions bot commented Nov 13, 2024

emerge-tools bot commented Nov 13, 2024

⚠️ 1 new unused protocol, 6 builds increased size

StripeSize 1.0 (1)com.stripe.StripeSize

StripeApplePaySize 1.0 (1)com.stripe.StripeApplePaySize

StripeFinancialConnectionsSize 1.0 (1)com.stripe.StripeFinancialConnectionsSize

StripePaymentsSize 1.0 (1)com.stripe.StripePaymentsSize

StripePaymentsUISize 1.0 (1)com.stripe.StripePaymentsUISize

StripePaymentSheetSize 1.0 (1)com.stripe.StripePaymentSheetSize

emerge-tools bot commented Nov 13, 2024

⚠️ 1 new unused protocol, 6 builds increased size

StripeSize 1.0 (1)com.stripe.StripeSize

StripeApplePaySize 1.0 (1)com.stripe.StripeApplePaySize

StripeFinancialConnectionsSize 1.0 (1)com.stripe.StripeFinancialConnectionsSize

StripePaymentsSize 1.0 (1)com.stripe.StripePaymentsSize

StripePaymentsUISize 1.0 (1)com.stripe.StripePaymentsUISize

StripePaymentSheetSize 1.0 (1)com.stripe.StripePaymentSheetSize

github-actions bot commented Nov 13, 2024

joyceqin-stripe commented Nov 13, 2024 •

edited

Loading

StripeSize 1.0 (1)
com.stripe.StripeSize

StripeApplePaySize 1.0 (1)
com.stripe.StripeApplePaySize

StripeFinancialConnectionsSize 1.0 (1)
com.stripe.StripeFinancialConnectionsSize

StripePaymentsSize 1.0 (1)
com.stripe.StripePaymentsSize

StripePaymentsUISize 1.0 (1)
com.stripe.StripePaymentsUISize

StripePaymentSheetSize 1.0 (1)
com.stripe.StripePaymentSheetSize

StripeSize 1.0 (1)
com.stripe.StripeSize

StripeApplePaySize 1.0 (1)
com.stripe.StripeApplePaySize

StripeFinancialConnectionsSize 1.0 (1)
com.stripe.StripeFinancialConnectionsSize

StripePaymentsSize 1.0 (1)
com.stripe.StripePaymentsSize

StripePaymentsUISize 1.0 (1)
com.stripe.StripePaymentsUISize

StripePaymentSheetSize 1.0 (1)
com.stripe.StripePaymentSheetSize