Regenerate with decimal_string enabled for v2 APIs#2310
Merged
jar-stripe merged 2 commits intomasterfrom Mar 20, 2026
Merged
Conversation
V2 API fields with `format: decimal` now generate as `float64` with proper struct tags (`json:",string"` and `form:",high_precision"`) instead of `*string`. Driven by sdk-codegen#3369. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Committed-By-Agent: claude
ea64f6a to
800fdf7
Compare
This was referenced Mar 19, 2026
mbroshi-stripe
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
V2 API decimal fields (e.g.
amounton billing meter events) were previously generated as plainstringtypes, even though the same fields in v1 are generated asfloat64withhigh_precisionform tags. A codegen workaround suppresseddecimal_stringtype mapping for all v2 APIs. That workaround has been removed and the root cause (a Go struct tag bug wherehigh_precisionleaked into json tags) fixed properly.What?
decimal_stringenabled for v2 APIsfloat64with correct struct tags (json:"field,string"+form:"field,high_precision") instead of plainstringjson:",string"tag handles decimal string serialization/deserialization natively — no SDK fix neededTesting
Integration tested against a live Stripe sandbox (6/6 tests passed):
float64deserialization from JSON string ✓float64zero-value when field absent ✓float64high precision (10 decimal places) ✓Amountstruct consolidation ✓float64percentOwnership ✓float64percentOwnership ✓See Also
Changelog
stringtofloat64withjson:",string"andform:",high_precision"struct tags. Code that passes these fields asstringwill need to usefloat64instead. Affected fields:PercentOwnershipPercentOwnershipV2CoreAccountIdentityIndividualRelationshipParams,V2CoreAccountCreateIdentityIndividualRelationshipParams,V2CoreAccountUpdateIdentityIndividualRelationshipParams,V2CoreAccountTokenIdentityIndividualRelationshipParams,V2CoreAccountTokenCreateIdentityIndividualRelationshipParams,V2CoreAccountsPersonRelationshipParams,V2CoreAccountsPersonCreateRelationshipParams,V2CoreAccountsPersonUpdateRelationshipParams,V2CoreAccountsPersonTokenRelationshipParams,V2CoreAccountsPersonTokenCreateRelationshipParams