Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add justfile, update readme, remove coveralls #1964

Merged
merged 6 commits into from
Jan 16, 2025
Merged

Conversation

xavdid-stripe
Copy link
Member

Why?

In an effort to modernize and simplify our local tooling, we're moving our dev commands from makefiles to justfiles. This is intended to be mostly a drop-in replacement, but some command names may change per standardization efforts.

What?

  • add justfile
  • tweak CI to use justfile
  • remove coveralls from CI

See Also

DEVSDK-2325

@xavdid-stripe xavdid-stripe requested review from a team and jar-stripe and removed request for a team January 13, 2025 02:20
.github/workflows/ci.yml Show resolved Hide resolved
justfile Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
Copy link
Contributor

@jar-stripe jar-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good overall; a couple of questions about things you removed from the README.md, but if those are covered elsewhere this is an easy 👍

@xavdid-stripe xavdid-stripe enabled auto-merge (squash) January 16, 2025 01:55
Copy link
Contributor

@jar-stripe jar-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xavdid-stripe xavdid-stripe merged commit 7a0ef1d into master Jan 16, 2025
12 checks passed
@xavdid-stripe xavdid-stripe deleted the DEVSDK-2325 branch January 16, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants