Skip to content

⚠️ Make tax_rate.tax_details expandable#3396

Merged
xavdid merged 1 commit into
masterfrom
RUN_DEVSDK-2478
Jun 5, 2026
Merged

⚠️ Make tax_rate.tax_details expandable#3396
xavdid merged 1 commit into
masterfrom
RUN_DEVSDK-2478

Conversation

@xavdid

@xavdid xavdid commented Jun 5, 2026

Copy link
Copy Markdown
Member

Why?

In the recent 2026-04-22.dahlia API version, we made tax_details expandable wherever they appear. Changing the type of a field is a breaking change in the SDKs, so the team made the decision to hold that field change out of the SDKs until our next major version in September (which is a fairly common pattern for us).

We figured that by keeping the field as as string, existing users wouldn't have to navigate a breaking change, but users who wanted to could expand and use as needed (after doing some manual type casting). This is true for our interpreted SDKs, but isn't in the compiled ones. In compiled SDKs, expanding tax_details fails at runtime because we try to deserialize an object into a string.

The feature needs to work, so we're biting the bullet and doing an out-of-band major in our compiled languages.

What?

  • regenerate SDK, which converts 4 usages of tax_rate.tax_details into expandable fields

See Also

@xavdid xavdid requested a review from a team as a code owner June 5, 2026 23:05
@xavdid xavdid requested review from jar-stripe and removed request for a team June 5, 2026 23:05
@xavdid xavdid enabled auto-merge (squash) June 5, 2026 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants