⚠️ Make tax_rate.tax_details expandable#3396
Merged
Merged
Conversation
jar-stripe
approved these changes
Jun 5, 2026
This was referenced Jun 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
In the recent
2026-04-22.dahliaAPI version, we madetax_detailsexpandable wherever they appear. Changing the type of a field is a breaking change in the SDKs, so the team made the decision to hold that field change out of the SDKs until our next major version in September (which is a fairly common pattern for us).We figured that by keeping the field as as string, existing users wouldn't have to navigate a breaking change, but users who wanted to could expand and use as needed (after doing some manual type casting). This is true for our interpreted SDKs, but isn't in the compiled ones. In compiled SDKs, expanding
tax_detailsfails at runtime because we try to deserialize an object into a string.The feature needs to work, so we're biting the bullet and doing an out-of-band major in our compiled languages.
What?
tax_rate.tax_detailsinto expandable fieldsSee Also