Add runtime support for V2 int64 string-encoded fields#3321
Merged
mbroshi-stripe merged 2 commits intomasterfrom Mar 18, 2026
Merged
Add runtime support for V2 int64 string-encoded fields#3321mbroshi-stripe merged 2 commits intomasterfrom
mbroshi-stripe merged 2 commits intomasterfrom
Conversation
a9e1266 to
e9cd51d
Compare
jar-stripe
approved these changes
Mar 18, 2026
This was referenced Mar 26, 2026
This was referenced Apr 13, 2026
This was referenced Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
V2 APIs represent int64 fields as JSON strings on the wire (e.g.
"12345"instead of12345) to avoid precision loss. The SDK should transparently convert between nativelongand this wire format so users don't need to handle string encoding themselves.What?
StringInt64Converter(Newtonsoft.Json) — reads string or integer tokens, writes as stringSTJStringInt64Converter(System.Text.Json, .NET 6+) — same behavior for STJ[JsonConverter(typeof(StringInt64Converter))]