Check if a datetime is in millis#3254
Merged
prathmesh-stripe merged 3 commits intomasterfrom Nov 18, 2025
Merged
Conversation
jar-stripe
approved these changes
Nov 18, 2025
|
Why not convert all those |
Contributor
Author
@kerams Thanks for the idea! Can you open an issue with that? That seems like a much bigger change, but we can consider it separately. |
This was referenced Nov 20, 2025
This was referenced Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
A bug was reported in #3253 where the Stripe API is returning a datetime in milliseconds instead of seconds. That's causing a
ArgumentOutOfRangeExceptionwhen trying to deserialize thelast_seen_atfield. This PR addresses that issue by detecting if a returned value is in millis or seconds before trying to deserialize it to aDateTime.What?
UnixDateTimeConverterandSTJUnixDateTimeConverterto convert large values as milliseconds and smaller values as seconds.See Also
Changelog