Fixes STJDefaultConverter to safely ignore unknown properties#3223
Merged
jar-stripe merged 1 commit intomasterfrom Oct 15, 2025
Merged
Fixes STJDefaultConverter to safely ignore unknown properties#3223jar-stripe merged 1 commit intomasterfrom
jar-stripe merged 1 commit intomasterfrom
Conversation
…is not known changed loop to a filter call for clarity
jar-stripe
requested review from
helenye-stripe
and removed request for
a team
prathmesh-stripe
approved these changes
Oct 15, 2025
Contributor
prathmesh-stripe
left a comment
prathmesh-stripe
left a comment
There was a problem hiding this comment.
I'll follow this up with a test case.
jar-stripe
added a commit
that referenced
this pull request
Oct 21, 2025
* update doc link (#3212) * Improve event notification example (#3217) * improve events example * update docs * added .net 9 to target frameworks excluded deprecated code in SystemNetHttpClient for .net 9 and above added justfile and script to install required sdk versions updated test commands to use .net 9 target (in justfile) deleted global.json updated build step in ci to read target frameworks from the project file * Revert "added .net 9 to target frameworks" This reverts commit 26a197a. * fixed STJDefaultConverter to advance the reader even if the property is not known (#3223) changed loop to a filter call for clarity * Added STJ tests for deserializing null values (#3224) * Add support for building on .NET 9 (#3222) --------- Co-authored-by: David Brownman <109395161+xavdid-stripe@users.noreply.github.com> Co-authored-by: Prathmesh Ranaut <165320323+prathmesh-stripe@users.noreply.github.com>
This was referenced Oct 30, 2025
This was referenced Nov 6, 2025
This was referenced Nov 20, 2025
This was referenced Dec 22, 2025
This was referenced Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
There is a bug in STJDefaultConverter where extra properties in the JSON could cause an exception when it is being deserialized. We currently do not support capturing extra properties into a separate object with STJ (like we do with Newtonsoft Json.NET) so for now we can safely discard these properties.
What?
See Also
Changelog