Fixed encoding of boolean query params#3104
Merged
jar-stripe merged 1 commit intomasterfrom Apr 17, 2025
Merged
Conversation
helenye-stripe
approved these changes
Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
The
ContentEncoderclass does not have a special case for encoding boolean query params, and .NET's bool ToString method outputs capitalized True or False. v1 apis would accept these or the lowercase versions true or false, but but v2 strictly requires the lowercase true or false. This PR updates ContentEncoder to correctly encode booleans for both API versions.What?
See Also