Skip to content

Remove Upcoming Lines API from SDK#3064

Merged
jar-stripe merged 2 commits intomasterfrom
jar/fix-failing-invoice-service
Mar 14, 2025
Merged

Remove Upcoming Lines API from SDK#3064
jar-stripe merged 2 commits intomasterfrom
jar/fix-failing-invoice-service

Conversation

@jar-stripe
Copy link
Copy Markdown
Contributor

@jar-stripe jar-stripe commented Mar 14, 2025

Why?

The stripe-dotnet SDK has some deprecated methods that referenced the /v1/invoices/upcoming and /v1/invoices/upcoming/lines APIs. These APIs are scheduled for removal in the upcoming version. This PR removes the deprecated methods in preparation for the upcoming change

What?

  • remove UpcomingLines service from Invoice service, and removed manually maintained methods that reference the UpcomingLines service objects

This PR also updates the description for the EventDestinations resource.

Changelog

  • ⚠️ Removes InvoiceUpcomingLinesService and all dependent objects.
  • ⚠️ Removes the UpcomingLines property in InvoiceService, and the ListUpcomingLineItems, ListUpcomingLineItemsAsync, ListUpcomingLineItemsAutoPaging, ListUpcomingLineItemsAutoPagingAsync, UpcomingLines, UpcomingLinesAsync , UpcomingLinesAutoPaging , and UpcomingLinesAutoPagingAsync methods from InvoiceService. Use CreatePreview or CreatePreviewAsync to create a preview invoice and then use existing InvoiceService methods with the preview invoice ID (see https://docs.stripe.com/invoicing/preview).
  • Adds CreatedGt, CreatedGte, CreatedLt, CreatedLte, and DeliverySuccess filter options to Stripe.V2.Core.EventListOptions.

modified manually maintained code to remove methods that referenced this service
removed broken tests
@jar-stripe jar-stripe marked this pull request as ready for review March 14, 2025 20:45
@jar-stripe jar-stripe requested a review from a team as a code owner March 14, 2025 20:45
@jar-stripe jar-stripe requested review from xavdid-stripe and removed request for a team March 14, 2025 20:45
@jar-stripe jar-stripe changed the title jar/fix failing invoice service Remove Upcoming Lines API from SDK Mar 14, 2025
@jar-stripe
Copy link
Copy Markdown
Contributor Author

jar-stripe commented Mar 14, 2025

This PR also adds V2. namespace to StripeList in the V2.Core.EventService. This is a no-op for the SDK user.

@jar-stripe jar-stripe merged commit 9214022 into master Mar 14, 2025
4 of 6 checks passed
@jar-stripe jar-stripe deleted the jar/fix-failing-invoice-service branch March 14, 2025 21:32
ramya-stripe added a commit that referenced this pull request Mar 19, 2025
* add codeowners file (#3055)

* Improved examples (#3054)

* changed Program to accept a command line argument with the name (relative to Examples namespace) of the example to run

* updated existing examples

* added usage instructions

* added just recipe

* Update generated code (#3050)

* Update generated code for v1463

* Update generated code for v1494

* Update generated code for v1495

* Update generated code for v1501

* Update generated code for v1505

---------

Co-authored-by: Stripe OpenAPI <105521251+stripe-openapi[bot]@users.noreply.github.com>
Co-authored-by: prathmesh-stripe <165320323+prathmesh-stripe@users.noreply.github.com>

* Bump version to 47.4.0

* Remove Upcoming Lines API from SDK (#3064)

* Revert changes to v2 apis

---------

Co-authored-by: David Brownman <109395161+xavdid-stripe@users.noreply.github.com>
Co-authored-by: jar-stripe <jar@stripe.com>
Co-authored-by: stripe-openapi[bot] <105521251+stripe-openapi[bot]@users.noreply.github.com>
Co-authored-by: Ramya Rao <ramya@stripe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants