Add an HTTP wrapper to the gRPC daemon #899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomelm
force-pushed
the
tomer/http-grpc-daemon
branch
from
8de37d4 to
cf232bf
Compare
ianjabour-stripe
approved these changes
Jul 14, 2022
There was a problem hiding this comment.
This LGTM, will defer to @vcheung-stripe being that he's got more context on the gRPC setup.
tomer-stripe
added a commit
that referenced
this pull request
Jul 19, 2022
This reverts commit 9c5f16d.
tomer-stripe
added a commit
that referenced
this pull request
Jul 19, 2022
tomer-stripe
added a commit
that referenced
this pull request
Jul 19, 2022
* The daemon can spin up an http grpc server in parallel for web clients * Go back to the non-hardcoded ip * Add comment for exported server function * Return the right header in the required header check for the daemon * When the request errors, mention both headers otherwise the logic gets weird * Remove extra newline Co-authored-by: Tomer Elmalem <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers
r? @vcheung-stripe @suz-stripe
cc @stripe/developer-products
Summary
I was working on a small side projects where I was trying to have an app talk to the Stripe CLI's gRPC interface. One problem I had is that the request client only supported HTTP which meant that it couldn't interface with the daemon directly. This PR wraps the gRPC daemon and spins up another server that supports all the gRPC functionality as an HTTP server.