Add murmur3 to hash module #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aadi-stripe
force-pushed
the
aadi/test-murmur
branch
2 times, most recently
from
4368b14
to
422768a
Compare
aadi-stripe
changed the title
sushain97
suggested changes
Sep 3, 2024
go/hashmodule/hashmodule.go
Outdated
| // md5, | ||
| // sha1, | ||
| // sha256, | ||
| // murmur3, |
There was a problem hiding this comment.
Ah yeah that's my formatter. Can fix
go/hashmodule/hashmodule.go
Outdated
| "md5": starlark.NewBuiltin("hash.md5", fnHash(md5.New)), | ||
| "sha1": starlark.NewBuiltin("hash.sha1", fnHash(sha1.New)), | ||
| "sha256": starlark.NewBuiltin("hash.sha256", fnHash(sha256.New)), | ||
| "murmur3_64": starlark.NewBuiltin("hash.murmur3_64", fnHash64(murmur3.New64)), |
There was a problem hiding this comment.
murmur3 above but murmur3_64 here. Former seems better to me.
aadi-stripe
force-pushed
the
aadi/test-murmur
branch
from
422768a
to
1fa0365
Compare
sushain97
approved these changes
Sep 4, 2024
sushain-stripe
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the description, we wanted to use murmur3, hence we'd like to add it to the hash module. We are experimenting with it internally at Stripe for some CI tooling, given its known better performance for fair distribution of a small set of inputs.