Skip to content

add windows support to stripe-mock action#189

Merged
xavdid merged 2 commits into
masterfrom
stripe-mock-windows
Jul 15, 2026
Merged

add windows support to stripe-mock action#189
xavdid merged 2 commits into
masterfrom
stripe-mock-windows

Conversation

@xavdid

@xavdid xavdid commented Jul 15, 2026

Copy link
Copy Markdown
Member

Why?

We're adding platform-specific logic to the SDKs, so we're also adding a windows test. Our stripe-mock action didn't support windows

The logic is pulled from the .NET CI, which did have a windows test. So I have pretty high confidence in it: stripe/stripe-dotnet | ci.yml#L171-L186

What?

  • add a windows path for the stripe-mock action
  • prettier changed some quotes

See Also

@xavdid
xavdid requested a review from jar-stripe July 15, 2026 18:08
@jar-stripe

jar-stripe commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

For posterity, we do that in .NET CI because you can't run linux containers on a windows runner in GHA: https://github.com/orgs/community/discussions/25491. If that ever changes (i.e. if we put out a windows image for stripe-mock or GH supports running linux containers on windows) we could change this back to always using a docker image.

@xavdid
xavdid merged commit 3df5f88 into master Jul 15, 2026
3 checks passed
@xavdid
xavdid deleted the stripe-mock-windows branch July 15, 2026 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants