-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(auto-rebalance): adds new and updated content for auto-rebalancing #10698
Conversation
- New procedure for triggering auto-rebalances on scaling - Updated node pool procedures to relect auto-rebalance enablement - Update to resource ststus list Signed-off-by: prmellor <[email protected]>
documentation/modules/cruise-control/proc-automating-rebalances.adoc
Outdated
Show resolved
Hide resolved
documentation/modules/cruise-control/proc-automating-rebalances.adoc
Outdated
Show resolved
Hide resolved
documentation/modules/cruise-control/proc-automating-rebalances.adoc
Outdated
Show resolved
Hide resolved
Signed-off-by: prmellor <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
documentation/assemblies/configuring/assembly-scaling-kafka-clusters.adoc
Outdated
Show resolved
Hide resolved
Signed-off-by: prmellor <[email protected]>
metadata: | ||
name: my-add-remove-brokers-rebalancing-template | ||
annotations: | ||
strimzi.io/rebalance-template: true # <1> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has to be "true"
I think ...
strimzi.io/rebalance-template: true # <1> | |
strimzi.io/rebalance-template: "true" # <1> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be strimzi.io/rebalance : template
as I pointed out in the previous comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just two nits. Thanks
You can apply the same template configuration for both scaling modes, use different configurations for each, or enable auto-rebalancing for only one mode. | ||
If `autorebalance` configuration is not set for a mode, auto-rebalancing will not occur for that mode. | ||
|
||
The template `KafkaRebalance` resource must include the `strimzi.io/rebalance-template: true` annotation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not true anymore btw. You have to add annotation:
strimzi.io/rebalance : template
right @ppatierno ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it changed the other way around ... from strimzi.io/rebalance : template
to strimzi.io/rebalance-template: "true"
... but the "true"
should be likely used here as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right @ppatierno ?
No as Jakub said, it's the other way around. I already asked Paul to fix it as he did.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I've kept as true, but added the string quotes
metadata: | ||
name: my-add-remove-brokers-rebalancing-template | ||
annotations: | ||
strimzi.io/rebalance-template: true # <1> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be strimzi.io/rebalance : template
as I pointed out in the previous comment
Signed-off-by: prmellor <[email protected]>
Documentation
Checklist
Please go through this checklist and make sure all applicable tasks have been done