Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add generic labels to docker images #10671

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Add generic labels to docker images #10671

merged 1 commit into from
Oct 3, 2024

Conversation

urbandan
Copy link
Contributor

@urbandan urbandan commented Oct 2, 2024

This change implements issue 10670.

Type of change

Select the type of your PR

  • Bugfix
  • Enhancement / new feature
  • Refactoring
  • Documentation

Description

This change adds a number of generic labels to all docker images built in the project. This change implements issue 10670.

Checklist

Please go through this checklist and make sure all applicable tasks have been done

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Check RBAC rights for Kubernetes / OpenShift roles
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging
  • Update CHANGELOG.md
  • Supply screenshots for visual changes, such as Grafana dashboards

@urbandan
Add generic labels to docker images
24c8ee1 
This change implements issue 10670.

Signed-off-by: Daniel Urban <[email protected]>
@urbandan urbandan mentioned this pull request Oct 2, 2024
Closed
@scholzj scholzj added this to the 0.44.0 milestone Oct 2, 2024
scholzj
scholzj approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good idea. Thanks for looking into this.

@scholzj scholzj linked an issue Oct 2, 2024 that may be closed by this pull request
[Enhancement]: Specify generic labels in docker images #10670
Closed
@scholzj scholzj requested a review from ppatierno October 2, 2024 18:13
@scholzj
Copy link
Member

scholzj commented Oct 2, 2024

/azp run acceptance

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

im-konge
im-konge approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@im-konge im-konge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :) Thanks!

@scholzj
Copy link
Member

scholzj commented Oct 3, 2024

Thanks for the PR @urbandan

@scholzj scholzj merged commit e38105a into strimzi:main Oct 3, 2024
15 checks passed
@urbandan urbandan deleted the image_labels branch October 3, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scholzj scholzj scholzj approved these changes

@ppatierno ppatierno ppatierno approved these changes

@im-konge im-konge im-konge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.44.0
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Specify generic labels in docker images
4 participants
@urbandan @scholzj @ppatierno @im-konge