[ST] Parallelize kubeClient interactions in AbstractUpgradeST #10514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhunyady
force-pushed
the
upgrade-test-parallelization
branch
2 times, most recently
from
23a0216
to
865a72c
Compare
Signed-off-by: Laszlo I. Hunyady <[email protected]>
lhunyady
force-pushed
the
upgrade-test-parallelization
branch
from
865a72c
to
6e80281
Compare
im-konge
reviewed
Aug 29, 2024
systemtest/src/test/java/io/strimzi/systemtest/upgrade/AbstractUpgradeST.java
Outdated
Show resolved
Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/upgrade/AbstractUpgradeST.java
Outdated
Show resolved
Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/upgrade/AbstractUpgradeST.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Lukáš Král <[email protected]> Signed-off-by: Laszlo I. Hunyady <[email protected]>
|
Thank you! I have applied them! |
|
/azp run upgrade |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@lhunyady there is ongoing minikube registry outage, the failure is not related to your changes. |
|
Thx, is there a tracking ticket for that? |
|
There are several issues opened on Minikube gh. I opened #10519 that should workaround the problem 🤞 |
|
/azp run build |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run upgrade |
|
Azure Pipelines successfully started running 1 pipeline(s). |
henryZrncik
approved these changes
Aug 30, 2024
im-konge
approved these changes
Aug 30, 2024
|
LGTM, thanks a lot for the PR @lhunyady ! |
|
Thank you @im-konge! Not sure what the next steps are, but from my point of view this PR can be merged! |
|
@lhunyady PRs require a review from 2 maintainers to be merged. I think that @see-quick or @Frawless will look at it next. But in any case, there is nothing you have to do right now. |
see-quick
approved these changes
Sep 2, 2024
|
Thank you everyone for the help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Parallelize kubeClient interactions in AbstractUpgradeSt