feat: ExecutionMode control for Flexible Processing #2535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doprez
reviewed
Dec 1, 2024
|
|
||
| namespace Stride.Engine.FlexibleProcessing | ||
| { | ||
| public interface IProcessorBase | ||
| { | ||
| /// <summary> The logic using this value expects it to be constant at runtime </summary> | ||
| ExecutionMode ExecutionMode => ExecutionMode.Runtime; |
There was a problem hiding this comment.
Do we want the default to act like a regular EntityProcessor for the sake of consistency?
There was a problem hiding this comment.
I think most users would actually expect their processors to only run at runtime out of the box, like script do. I understand that it's a bit counter intuitive when you come from how EntityProcessor work out of the box, which is why I wanted to change that as well but that's a far bigger breaking change
There was a problem hiding this comment.
With the amount of times I have crashed the editor due to me forgetting to add ExecutionMode I fully agree with that logic.
Sounds good to me then.
Doprez
approved these changes
Dec 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
See title
Related Issue
Fix #2532
Types of changes
Checklist