refactor: FreeImage dependency update #2531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's a bunch of tabs/space mismatch in this PR, can't merge it as is sadly |
Eideren
reviewed
Dec 1, 2024
| @@ -2790,14 +2779,12 @@ public TimeSpan? TimeStamp | |||
| get | |||
| { | |||
| FIURational[] stamp = GetTagArray<FIURational>("GPSTimeStamp"); | |||
| if ((stamp == null) || stamp.Length != 3) | |||
| if (stamp is not { Length: 3 }) | |||
There was a problem hiding this comment.
I think this one is just more confusing than the previous one; the negative and positive are merged into the same comparison.
Besides those two comments it looks quite good, thanks @Jklawreszuk !
There was a problem hiding this comment.
No problem , I think it is more readable but I understand that it can be confusing, so I reverted it 😀
Jklawreszuk
force-pushed
the
freeimage
branch
from
140b4e8 to
e847bde
Compare
|
Huh... Maybe Rider uses spaces instead of tabs when I fixed the warnings. Now I formatted with VSCode, so I hope that will do |
Eideren
changed the title
|
Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
This PR mainly removes the duplicate FreeImageNET source code, which is not used anywhere.
In addition, I decided to refactor code and remove the useless compatibility with
System.Drawing.Bitmap, which is also not used anywhere.Types of changes
Checklist