Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SpriteBatch rotation logic to original code #2458

Merged
merged 1 commit into from
Sep 21, 2024

Conversation

Basewq
Copy link
Contributor

@Basewq Basewq commented Sep 21, 2024

PR Details

As per

npLolSincosf(drawInfo->Rotation, &rotation.Y, &rotation.X);

the original code assigned SinCos to (Y, X), but the C# code changed to (X, Y)

This changes it back to restore the original behavior.

Related Issue

Fixes #2456
Caused by #1896

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@Eideren Eideren changed the title Fix SpriteBatch rotation logic to original code fix: SpriteBatch rotation logic to original code Sep 21, 2024
@Eideren Eideren merged commit ae92baa into stride3d:master Sep 21, 2024
2 checks passed
@Eideren
Copy link
Collaborator

Eideren commented Sep 21, 2024

Thanks !

@Basewq Basewq deleted the sb_rot_fix branch September 23, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breaking SpriteBatch behavior change starting from Stride 4.2.0
3 participants