Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Modernize PVRTexLib dependency #2342

Merged
merged 2 commits into from
Jul 6, 2024
Merged

Conversation

Jklawreszuk
Copy link
Collaborator

@Jklawreszuk Jklawreszuk commented Jun 21, 2024

PR Details

My PR updates PVRTexLib to the latest version and adds a shared library for Linux. In the process, I refactored PVRTWrapper and removed methods that were not used anywhere.

Note : To be honest I don't know how to test the changes yet so my changes may not work properly Done

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@Jklawreszuk Jklawreszuk marked this pull request as draft June 21, 2024 14:04
@Jklawreszuk Jklawreszuk marked this pull request as ready for review June 26, 2024 20:12
@Jklawreszuk
Copy link
Collaborator Author

PR should be ready for review. I made simple program to test all the methods and it works as expected :)
Perhaps it would be also useful to rewrite the current TextureConverter tests (project currently does not work)
Program.txt

@Eideren Eideren merged commit 6993d9c into stride3d:master Jul 6, 2024
14 checks passed
@Eideren
Copy link
Collaborator

Eideren commented Jul 6, 2024

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants