Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Make FastList Obsolete #2332

Merged
merged 1 commit into from
Jun 17, 2024
Merged

refactor: Make FastList Obsolete #2332

merged 1 commit into from
Jun 17, 2024

Conversation

Doprez
Copy link
Contributor

@Doprez Doprez commented Jun 15, 2024 •
edited
Loading

PR Details

Added info on the deprecation of FasLists list. Better alternatives have been made easier since .NET 5+ to make the base List class twice as fast.

339938102-cbc58c9c-406b-4465-a928-d65fe006928c

Related Issue

#2298

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@Doprez Doprez marked this pull request as ready for review June 15, 2024 20:28
@Doprez Doprez changed the title added info on reasons for obsoletion Make FastList Obsolete Jun 16, 2024
@Eideren Eideren added the area-Core Issue of the engine unrelated to other defined areas label Jun 17, 2024
@Eideren Eideren changed the title Make FastList Obsolete refactor: Make FastList Obsolete Jun 17, 2024
@Eideren Eideren merged commit ab954ea into stride3d:master Jun 17, 2024
2 checks passed
@Eideren
Copy link
Collaborator

Eideren commented Jun 17, 2024

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jklawreszuk Jklawreszuk Jklawreszuk approved these changes

Assignees
No one assigned
Labels
area-Core Issue of the engine unrelated to other defined areas
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Doprez @Eideren @Jklawreszuk