Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Set initial visibility for ModelComponent gizmos off #2321

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

Eideren
Copy link
Collaborator

@Eideren Eideren commented Jun 12, 2024

PR Details

Following #2294 - No need to have them visible by default I would think, checking with @kristian15959 just in case ?

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@Eideren Eideren changed the title [Editor] Set initial visibility for ModelComponent gizmos off style: Set initial visibility for ModelComponent gizmos off Jun 12, 2024
@kristian15959
Copy link
Contributor

kristian15959 commented Jun 18, 2024

Hi, sorry for the late reply. It's something I wanted to add aswell just did not know where to find the setting for it. Thanks for this change I definitely approve :)

@Eideren Eideren merged commit f1bbc4e into stride3d:master Jun 18, 2024
2 checks passed
@Eideren Eideren deleted the model_gizmos branch June 18, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants