fix: UI overridden margin in derived controls being reset #2310
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
As per #2048, Margin is a struct
Thickness
, with itself holding float fields (Left
,Right
, etc).If an object has a
Thickness
struct as a field/property and you override it in a derived asset, it is marked as overridden, however the fields of theThickness
are not marked overridden.When
AssetPropertyGraph
encounters theThickness
's fields it was not aware its parent has been marked overridden so it mistaken itself as not overridden and overwrites itself with the value from the base asset.This change ensures any encountered member (field/property) that is a value type must check if it is part of another value type that may be marked overridden, and reject taking the base asset's value if this is the case.
2nd commit is to fix some typos.
Related Issue
Fixes #2048
Types of changes
Checklist