Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix inconsistent FileVersion test #2297

Merged
merged 2 commits into from
May 31, 2024
Merged

Conversation

Eideren
Copy link
Collaborator

@Eideren Eideren commented May 29, 2024

PR Details

This test occasionally fails because the test runner is too slow to process some of the requests, ensured we don't have an arbitrary 500ms timeout.

Related Issue

https://teamcity.stride3d.net/buildConfiguration/Engine_Tests_WindowsSimple/25340?expandBuildDeploymentsSection=false&hideTestsFromDependencies=false&expandBuildTestsSection=true&hideProblemsFromDependencies=false&expandBuildProblemsSection=true&expandBuildChangesSection=true

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@Eideren Eideren changed the title tests: Fix inconsistent FileVersion test test: Fix inconsistent FileVersion test May 29, 2024
@Eideren
Copy link
Collaborator Author

Eideren commented May 31, 2024

Thanks for reviewing @manio143 - merging this in

@Eideren Eideren merged commit 419b964 into stride3d:master May 31, 2024
2 checks passed
@Eideren Eideren deleted the fix_filetest branch May 31, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants