Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adjust copying exe to nuget package lib folder #2290

Merged
merged 1 commit into from
May 28, 2024

Conversation

Jklawreszuk
Copy link
Collaborator

PR Details

PR relates to my other recent PR (#2279).
When now Asset.CompilerApp is a cross-platform project, the project does not generate an exe file which may cause an error when generating a nuget package, because currently Stride.NuGetResolver.Targets.projitems tries to copy Asset.CompilerApp.exe even though it does not exist.

Probably when Gamestudio will be cross-platform this file should be revisited.

Related Issue

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@Eideren Eideren merged commit ba1f0d4 into stride3d:master May 28, 2024
13 checks passed
@Eideren
Copy link
Collaborator

Eideren commented May 28, 2024

Thanks !

@Jklawreszuk Jklawreszuk deleted the nugetresolv branch May 28, 2024 10:28
@Kryptos-FR Kryptos-FR changed the title fix: Adjust coping exe to nuget package lib folder fix: Adjust copying exe to nuget package lib folder May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants