Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Regression of new FBX importer on behalf of Noah #2246

Merged
merged 93 commits into from
May 18, 2024
Merged

fix: Regression of new FBX importer on behalf of Noah #2246

merged 93 commits into from
May 18, 2024

Conversation

Doprez
Copy link
Contributor

@Doprez Doprez commented May 14, 2024

PR Details

Adds Noahs Fix for a regression where the AssImp library didnt import FBX embedded textures.

Description

Tested importing FBX file with embeeded textures here
image

Related Issue

#2213

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

noa7 and others added 30 commits January 30, 2024 07:38
@noa7
BASE COMM
ed0e939
@noa7
Updates on Shader and resource marshaling
a3f044a
@noa7
Update- cleanup
8a3c13f
@noa7
Updates- clean up
a679906
@noa7
Updates
afe10c0
@noa7707
Updates as by Eidren & IXLLEGACYIXL on Github PR review
0a516fd
@Noah7071
Update shader- remove commented test code
6649b09
@Noah7071
Update: Clean up to effect class & shader
6ed75b6
@Noah7071
Scale Factor moved to Importer
5db94d9
@Noah7071
Removed extra class Vec4
c04c84d
@Noah7071
Fix to update scale factor in impoter
e66c0c8
@Noah7071
Normal fix on blendshapes
36c3daf
@Noah7071
Normal fix
06c130b
@Noah7071
IMPORTER CKECIIN
1751b13
@Noah7071
Importer
af97e33
@Noah7071
Incorporating Kryptos feedback on PR
b479aac
@Noah7071
Incorporating doprez feedback
f492fc5
@Noah7071
Updated .props to remove Assimp from Runtime refs
52bb440
@Noah7071
Feedback from Jklawreszuk
67fe225
@Noah7071
Removed workspace file, Jklawreszuk
396b3e3
@Noah7071
Feedback from IXLLEGACYIXL
d8bed82
@Noah7071
Account for default scaling
7cbd671
@Noah7071
Removed Assimp feedback Wolffy101
3e63b07
@Noah7071
Multiple Animation
3374082
@Noah7071
Removed test leftover code
15b1791
@Noah7071
UI update to give option to(or not to) import animatioms
6a292b4
@Noah7071
Feedback empty spaces @Kryptos
ba707a8
@Noah7071
BlendShape+Importer
167112b 
1. Handling large blendshape data (static + dynamic)
2. Upding importer for root motion animation
@Noah7071
PR Feedback
87cd7cd
@Noah7071
PR Feedback
0de8d50
@Doprez Doprez marked this pull request as ready for review May 14, 2024 21:16
@Doprez
Copy link
Contributor Author

Doprez commented May 14, 2024

Found one more issue, will fix soon.

@Doprez
Copy link
Contributor Author

Doprez commented May 14, 2024

@Eideren should be good to review this to finish @Noah7071 work on the importer conversion. Tested a few files and there havent been any new errors from before that I have found.

Also debugging this is really nice now :)

@Eideren
Copy link
Collaborator

Eideren commented May 18, 2024

Looks good otherwise, thanks for pulling this in @Doprez !

@Eideren Eideren changed the title Fix regression PR on behalf of Noah fix: Regression of new FBX importer on behalf of Noah May 18, 2024
@Eideren Eideren merged commit b3e3c74 into stride3d:master May 18, 2024
2 checks passed
@Eideren
Copy link
Collaborator

Eideren commented May 18, 2024

Thanks !

@Doprez Doprez mentioned this pull request May 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eideren Eideren Eideren left review comments

Assignees
No one assigned
Labels
area-Asset
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Doprez @Eideren @noa7 @noa7707 @Noah7071