Net6+VS2022 support #1126

jasonswearingen · 2021-08-23T15:25:56Z

PR Details

Net6+VS2022 support. Should be put into a separate branch for now. The following things need to be fixed before putting in master:

VS2022 support only. VS2019 is broken due to VS2022 support #1119 should support both
VSPlugin build is broken. Its build process needs to be updated to a x64 system.
Net6 is in preview. there may be breaking changes to the runtime in the next couple months before it's RTW

Description

upgrade stride to target DotNet6.0

IT IS DONE/COMPLETE. I'm done so it's really just up to Stride contribs to decide when/where to merge.

Related Issue

see #1125 for detailed description

Motivation and Context

please see the related issue

Types of changes

Docs change / refactoring / dependency upgrade
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist

My change requires a change to the documentation.
I have added tests to cover my changes.
All new and existing tests passed.

…eManagement and use it's internal references instead

… a version supporting Net6, and include Netonsoft.Json that used to be bundled with the old version.

CLAassistant · 2021-08-23T15:26:04Z

All committers have signed the CLA.

Eideren

Thanks !
Did you try to create a project under net5 and then open that project with the net6 gamestudio ?
You mentioned the vs plugin being broken over on #1125 is that building the plugin or using it inside of VS.
If it's building then I would think we should take care of that before we merge this in.

sources/targets/Stride.Core.props

.vscode/settings.json

build/Stride.sln.DotSettings

sources/core/Stride.Core.Design/Stride.Core.Design.csproj

sources/editor/Stride.Editor/Stride.Editor.csproj

user settings autogen

jasonswearingen · 2021-08-25T02:31:07Z

Did you try to create a project under net5 and then open that project with the net6 gamestudio ?

Yes that works fine. However I just discovered that running a project from within GameStudio fails due to nuget not finding a Microsoft.Net.HostModel assembly v6.0.0. It seems to be a sub-reference and I can't seem to solve this. It works. see update on 2021.08.28

The workaround is to run the game project from visual studio.

You mentioned the vs plugin being broken over on #1125 is that building the plugin or using it inside of VS.
If it's building then I would think we should take care of that before we merge this in.

It is not building. building fails with

Severity	Code	Description	Project	File	Line	Suppression State
Error	VSSDK1000	Failed to load 'C:\Users\Jason\.nuget\packages\microsoft.vssdk.buildtools\15.0.26201\tools\VSSDK\bin\VSCT.exe' Assembly. Could not load file or assembly 'file:///C:\Users\Jason\.nuget\packages\microsoft.vssdk.buildtools\15.0.26201\tools\VSSDK\bin\VSCT.exe' or one of its dependencies. An attempt was made to load a program with an incorrect format.	Stride.VisualStudio.Package	C:\Users\Jason\.nuget\packages\microsoft.vssdk.buildtools\15.0.26201\tools\VSSDK\Microsoft.VsSDK.Common.targets	128

which is because VSCT.exe is a 32bit app being executed by a 64bit build

jasonswearingen · 2021-08-25T02:32:37Z

I don't have the expertise to fix the VSPlugin ~~or the Gamestudio running project problems.~~

jasonswearingen · 2021-08-25T12:48:38Z

@xen2 could you please make a vs2022-net6 branch for this to be pulled into. There are some outstanding issues beyond my ability to fix, plus some ecosystem incompatibilities that should resolve by the time Net6 goes to RTW

…ange

jasonswearingen · 2021-08-29T02:10:40Z

update: Running game studio projects works if done through the Game Studio stand-alone (run from the launcher, not via Visual Studio). So the only thing that needs fixing is the VS Plugin.

I tested by opening the Stride Launcher, adding the local build, then run that gameStudio and loaded various projects

xen2 · 2021-08-29T10:31:03Z

Nice work!
I will integrate it directly as a branch (that we can merge in master as soon as .NET 6 is officially released)

xen2 · 2021-08-29T10:32:21Z

Longer term we might also want to switch mobile to net6.0-android/ios (of course, not part of this PR and we can still release with current TFM for mobile so nothing mandatory)

was hoping it would help resolve build hanging issues. It might have helped but was not a solution.

…ncies. was hoping it would help fix runtime IL bug with animation system, but it did not help. see: #1136

jasonswearingen · 2021-09-02T02:24:14Z

~~This PR is the minimum to get net6+VS2022 working.~~

~~additional unnecessary updates can be found in https://github.com/jasonswearingen/stride/tree/net6-unnecessary-build-updates~~

~~The maintainers may consider merging those also.~~

Because of how much time it takes to maintain a branch (merging building and testing) I am cutting the net6 work to a single branch. the optional stuff is now merged into the main vs2022-net6 work branch.

# build/Stride.Launcher.Build.props # samples/Audio/SimpleAudio/SimpleAudio.Windows/SimpleAudio.Windows.csproj # samples/Games/JumpyJet/JumpyJet.Windows/JumpyJet.Windows.csproj # samples/Games/SpaceEscape/SpaceEscape.Windows/SpaceEscape.Windows.csproj # samples/Graphics/AnimatedModel/AnimatedModel.Windows/AnimatedModel.Windows.csproj # samples/Graphics/CustomEffect/CustomEffect.Windows/CustomEffect.Windows.csproj # samples/Graphics/MaterialShader/MaterialShader.Windows/MaterialShader.Windows.csproj # samples/Graphics/SpriteFonts/SpriteFonts.Windows/SpriteFonts.Windows.csproj # samples/Graphics/SpriteStudioDemo/SpriteStudioDemo.Windows/SpriteStudioDemo.Windows.csproj # samples/Input/GravitySensor/GravitySensor.Windows/GravitySensor.Windows.csproj # samples/Input/TouchInputs/TouchInputs.Windows/TouchInputs.Windows.csproj # samples/Particles/ParticlesSample/ParticlesSample.Windows/ParticlesSample.Windows.csproj # samples/Physics/PhysicsSample/PhysicsSample.Windows/PhysicsSample.Windows.csproj # samples/Templates/FirstPersonShooter/FirstPersonShooter/FirstPersonShooter.Windows/FirstPersonShooter.Windows.csproj # samples/Templates/ThirdPersonPlatformer/ThirdPersonPlatformer/ThirdPersonPlatformer.Windows/ThirdPersonPlatformer.Windows.csproj # samples/Templates/TopDownRPG/TopDownRPG/TopDownRPG.Windows/TopDownRPG.Windows.csproj # samples/Templates/VRSandbox/VRSandbox/VRSandbox.Windows/VRSandbox.Windows.csproj # samples/Tutorials/CSharpBeginner/CSharpBeginner/CSharpBeginner.Windows/CSharpBeginner.Windows.csproj # samples/UI/GameMenu/GameMenu.Windows/GameMenu.Windows.csproj # samples/UI/UIElementLink/UIElementLink.Windows/UIElementLink.Windows.csproj # samples/UI/UIParticles/UIParticles.Windows/UIParticles.Windows.csproj # sources/assets/Stride.Core.Assets.CompilerApp/build/Stride.Core.Assets.CompilerApp.targets # sources/launcher/Stride.Launcher/Stride.Launcher.csproj # sources/shared/Stride.NuGetResolver/Stride.NuGetResolver.projitems # sources/targets/Stride.Core.TargetFrameworks.Editor.props # sources/targets/Stride.Core.props # sources/tools/Stride.NuGetLoader/Stride.NuGetLoader.csproj

)

…See #1136 (comment) This commit takes my "last known good" net6 work prior to merging [de0a0cb] and verifies build. I am integrating in the non-required net6 work because of how time consuming it is to verify+maintain each branch. Tracking this issue down and reproducing takes aproximately 1 hour per commit. So to reduce this waste of time I will be maintaining a single net6 branch. This commit removes some test projects from the stride solutions

…rApp.exe merge issue from [de0a0cb] .

…n't actually use the new LoaderToolLocator process yet

# Conflicts: # deps/AssemblyProcessor/netstandard2.0/Stride.Core.AssemblyProcessor.Packed.dll # deps/AssemblyProcessor/netstandard2.0/Stride.Core.AssemblyProcessor.Packed.dll.hash # deps/AssemblyProcessor/netstandard2.0/Stride.Core.AssemblyProcessor.Packed.pdb # deps/AssemblyProcessor/netstandard2.0/Stride.Core.AssemblyProcessor.dll # deps/AssemblyProcessor/netstandard2.0/Stride.Core.AssemblyProcessor.pdb # sources/assets/Stride.Core.Assets.CompilerApp/build/Stride.Core.Assets.CompilerApp.targets

jasonswearingen · 2021-09-07T20:00:29Z

merged xen's fix for UpdateEngine broken (see #1136 )
also applied other bugfixes to CompilerApp changes made in master branch. now working again.

jasonswearingen · 2021-09-12T16:15:34Z

merged stride/master work. auto-merge. didn't test, but glance at the changes show nothing related.

xen2 · 2021-11-03T12:20:38Z

Regarding VS2022 support:
#1119 is supposedly fixed in preview 5+ and RC3+
https://developercommunity.visualstudio.com/t/C-projects-are-targeting-Visual-Studio/1506031#T-N1565178

xen2 · 2021-11-03T14:33:09Z

Gave a quick try to latest VS2022 + .NET 6
Ran into some issues with NuGet dll clashes between ours and MSBuild (again!).

I think one way to fix that once and for all would be to call MSBuild using out-of-process nodes. That way, all the MSBuild dependencies won't be loaded in GameStudio/CompilerApp process.
However it looks like it's currently broken with .NET Core. I investigated and submitted a PR:
dotnet/msbuild#7013
Crossing fingers that it can be merged in time to be in .NET Core 6.0.1xx dailies soon and VS2022 RTM.

jasonswearingen added 5 commits August 21, 2021 07:31

basic VS2022 support: update vcxproj to use tools v143

015dcaf

WIP: move to net6

94d8169

net6 + vs2022 working build/run of gamestudio

f59a355

WIP: fixing Nuget References. Remove reference to Stride.NuGet.Packag…

b80d398

…eManagement and use it's internal references instead

update old Nuget reference to Microsoft.Extensions.DependencyModel to…

f068d4a

… a version supporting Net6, and include Netonsoft.Json that used to be bundled with the old version.

jasonswearingen changed the title ~~[Breaking Change] Net6+VS2022 support.~~ Net6+VS2022 support. Aug 23, 2021

jasonswearingen marked this pull request as ready for review August 24, 2021 04:00

Eideren reviewed Aug 24, 2021

View reviewed changes

jasonswearingen changed the title ~~Net6+VS2022 support.~~ Net6+VS2022 support 🚧 Aug 24, 2021

jasonswearingen added 3 commits August 24, 2021 06:52

Delete settings.json

e7cc699

user settings autogen

update comment for lang 10.0

88f6252

remove unneeded ref

b41c9fe

jasonswearingen changed the title ~~Net6+VS2022 support 🚧~~ Net6+VS2022 support Aug 25, 2021

remove Resharper autoplaced config value

79b89c1

jasonswearingen added 2 commits August 27, 2021 13:10

change version suffix from "-beta" to "-net6" to represent runtime ch…

d2752cd

…ange

personalizations for my net6 R&D environment

1f70809

jasonswearingen mentioned this pull request Aug 29, 2021

[Net6] UpdateEngine codegen broken on Net6 #1136

Closed

jasonswearingen added 3 commits September 1, 2021 19:18

[build] update msbuild to 16.11.0 from 16.0.461

acd969a

was hoping it would help resolve build hanging issues. It might have helped but was not a solution.

[IL Injection] update Stride.Core.AssemblyProcessor to latest depende…

26ce828

…ncies. was hoping it would help fix runtime IL bug with animation system, but it did not help. see: #1136

Merge branch 'net6-unnecessary-build-updates' into jason-scratch

b7971bd

jasonswearingen added 2 commits September 1, 2021 19:59

minor path fix for merge from master

f5827af

xen2 and others added 8 commits September 6, 2021 12:13

[AssemblyProcessor] Fixed UpdateEngine to works with .NET 6 (fixes #1136

5e82e0c

)

Merge commit 'a0fdc3d7cc0c3c9cc7576ba66c9c11c00d0e4150' into net-tmp3

82161cc

Merge branch 'net6-tmp' into net-tmp3 WIP: Stride.Core.Assets.Compile…

f3a376c

…rApp.exe merge issue from [de0a0cb] .

partial checkin of CompilerApp work. this includes the files but does…

9df8150

…n't actually use the new LoaderToolLocator process yet

finish merge of CompilerApp work. (broken)

6c9c45e

bugfix CompilerApp checkin

e44a7ca

Merge branch 'stride3d:master' into vs2022-net6

291464d

xen2 merged commit 9374d4f into stride3d:master Nov 10, 2021

Uh oh!

Net6+VS2022 support #1126

Net6+VS2022 support #1126

Uh oh!

Conversation

jasonswearingen commented Aug 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Details

Description

Related Issue

Motivation and Context

Types of changes

Checklist

Uh oh!

CLAassistant commented Aug 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Eideren left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jasonswearingen commented Aug 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jasonswearingen commented Aug 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jasonswearingen commented Aug 25, 2021

Uh oh!

jasonswearingen commented Aug 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xen2 commented Aug 29, 2021

Uh oh!

xen2 commented Aug 29, 2021

Uh oh!

jasonswearingen commented Sep 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jasonswearingen commented Sep 7, 2021

Uh oh!

jasonswearingen commented Sep 12, 2021

Uh oh!

xen2 commented Nov 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xen2 commented Nov 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jasonswearingen commented Aug 23, 2021 •

edited

Loading

CLAassistant commented Aug 23, 2021 •

edited

Loading

jasonswearingen commented Aug 25, 2021 •

edited

Loading

jasonswearingen commented Aug 25, 2021 •

edited

Loading

jasonswearingen commented Aug 29, 2021 •

edited

Loading

jasonswearingen commented Sep 2, 2021 •

edited

Loading

xen2 commented Nov 3, 2021 •

edited

Loading

xen2 commented Nov 3, 2021 •

edited

Loading