Skip to content

assert.EqualValues: improve test coverage to 100% #1763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2025
Merged

assert.EqualValues: improve test coverage to 100% #1763

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 17 additions & 6 deletions assert/assertions_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -978,15 +978,15 @@ func TestNotEqual(t *testing.T) {
}
}

func TestNotEqualValues(t *testing.T) {
func TestEqualValuesAndNotEqualValues(t *testing.T) {
t.Parallel()

mockT := new(testing.T)

cases := []struct {
expected interface{}
actual interface{}
result bool
expected interface{}
actual interface{}
notEqualResult bool // result for NotEqualValues
}{
// cases that are expected not to match
{"Hello World", "Hello World!", true},
Expand All @@ -1013,11 +1013,22 @@ func TestNotEqualValues(t *testing.T) {
}

for _, c := range cases {
// Test NotEqualValues
t.Run(fmt.Sprintf("NotEqualValues(%#v, %#v)", c.expected, c.actual), func(t *testing.T) {
res := NotEqualValues(mockT, c.expected, c.actual)

if res != c.result {
t.Errorf("NotEqualValues(%#v, %#v) should return %#v", c.expected, c.actual, c.result)
if res != c.notEqualResult {
t.Errorf("NotEqualValues(%#v, %#v) should return %#v", c.expected, c.actual, c.notEqualResult)
}
})

// Test EqualValues (inverse of NotEqualValues)
t.Run(fmt.Sprintf("EqualValues(%#v, %#v)", c.expected, c.actual), func(t *testing.T) {
expectedEqualResult := !c.notEqualResult // EqualValues should return opposite of NotEqualValues
res := EqualValues(mockT, c.expected, c.actual)

if res != expectedEqualResult {
t.Errorf("EqualValues(%#v, %#v) should return %#v", c.expected, c.actual, expectedEqualResult)
}
})
}
Expand Down