-
-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use kotlin.test instead of JUnit #5220
Use kotlin.test instead of JUnit #5220
Conversation
Oh, cool! For me, * imports for the test framework stuff is fine. |
So change all the test imports to What do we do about the new test failure? Any idea? I haven't found anything helpful after searching the web. |
Some other contributors (including me) prefer non-star imports, because you can more easily see where an import is coming from, also without an IDE. So I'd say let's leave it as it is. |
It's up to you, I'm fine with it either way. Especially for tests though, IMO it is not necessary to know where the particular Regarding the test failure - it concerns the |
Yes and yes
Any hint on where to read up on this? A quick search didn't return anything useful. |
Java auto boxes (and unboxes) primitive types like long into objects like Long in some circumstaces. But anyway, its just a hunch, it could not be related at all.
Am 28. August 2023 17:46:17 MESZ schrieb riQQ ***@***.***>:
…> Regarding the test failure - it concerns the `androidTests`, no? I understand that you only changed the `tests`.
Yes and yes
> Anyway, I guess it is some kind of auto-boxing failure.
Any hint on where to read up on this? A quick search didn't return anything useful.
--
Reply to this email directly or view it on GitHub:
#5220 (comment)
You are receiving this because you commented.
Message ID: ***@***.***>
|
Almost everything works, but there is one new test failure in
androidTest
NoteQuestsHiddenDaoTest.getNewerThan
on a Pixel 4 emulator that I don't know what it's caused by:The error occurs in line 49
assertEquals(2L, result.noteId)
.StreetComplete/app/src/androidTest/java/de/westnordost/streetcomplete/data/osmnotes/notequests/NoteQuestsHiddenDaoTest.kt
Lines 43 to 50 in 7063485
And another question regarding code style of imports and consistency.
Some files use star import à la
import org.junit.Assert.*
. Should this be kept, all files changed to star import or all files changed to explicit imports?