-
-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggest last answers in fire hydrant diameter quest #4369
Suggest last answers in fire hydrant diameter quest #4369
Conversation
app/src/main/java/de/westnordost/streetcomplete/util/LastPickedValuesStore.kt
Outdated
Show resolved
Hide resolved
Hmm, I have some reservations against this:
|
I don't feel too strongly either way about this, and I've only answered this quest a few times so far, but some general thoughts.
Although it is a bigger number so a few extra digits to type too.
It would be much slower to use a drop-down or similar, and an extra click, for the same effect.
While I'd certainly appreciate more map space, would putting the presets at the top of the form solve it (assuming you can reach the buttons comfortably), then the mostly irrelevant bottom of the form could remain hidden on smaller screens. |
As @peternewman said, the numbers are longer for fire hydrant diameters. There aren't as many fire hydrant quests as building levels quests of course, but in my town there's usually one every 40 meters or so. So it's still one of the more frequent quests. Especially when answering the quest with the phone mounted to a bike handlebar (as I often do), entering a diameter via the keyboard requires stopping the bike. I know that's not a common use case though.
We could also overlay the buttons over the hydrant sign, that way it won't take up any extra space. Since the button(s) will only be shown anyway after having solved the quest at least once (and the bottom of the signs is faded), nothing important will be hidden.
I don't think the UI is difficult to understand, do you? Do you have a better suggestion?
Most of the heavy lifting happens in
Yeah, that duplication can likely be avoided. |
Co-authored-by: smichel17 <[email protected]>
The street name quest has a ▼ button next to the input which lets you one of the nearby road names. This would be an idea, it takes up practically no extra space and (thus) does not populate the UI with more buttons (the busier UI, i.e. the more knobs and wheels to turn, the less clear it gets). The only downside is that one extra tap to open the dropdown is required. |
The state of the dropdown could be persisted. Then it's one additional tap only once. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise, the code looks spotless
<?xml version="1.0" encoding="utf-8"?> | ||
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android" | ||
xmlns:tools="http://schemas.android.com/tools" | ||
style="@style/Widget.AppCompat.Button.Small" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Independently of the rest, I wonder if there is a reason why we do not use material design theme here? In particular, I guess the material-style to choose here would be the "outlined button"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess there is no reason, I just used the default style that the android layout designer suggested.
Are you editing in area where it really helps? In my area I get this question maybe once per editing session (and in Poland so far 100% of hydrants were missing such sign, but that is a different story) |
Yes, as I wrote above, in my town there's usually a fire hydrant every 40 meters or so. Most are mapped but were lacking the diameter (although that changed because I answered the quest for most of them already). Tapping a button would have been much quicker than having to enter one of the same three common diameters every time. |
So, did you consider a ▼ button? |
I didn't (and still don't) have much time to try to change this. But I'll get to it in the next weeks. |
Well, unless you think your current solution is better. But IMO when compared, one tap more is better than having 1-5 buttons more in the UI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that you think it's better :-)
Similar to the building levels quest. Most cities have only a handful of different diameters, and in one street there's usually only one or two different ones. Clicking a button is much faster than entering the value manually each time.