Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap some osmapi exceptions in Kotlin exceptions #2821

Merged
merged 3 commits into from
May 2, 2021
Merged

Wrap some osmapi exceptions in Kotlin exceptions #2821

merged 3 commits into from
May 2, 2021

Conversation

FloEdelmann
Copy link
Member

Closes #2818.

FloEdelmann
FloEdelmann commented Apr 28, 2021
View reviewed changes
Copy link
Member Author

@FloEdelmann FloEdelmann left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What should I do about these few missing ones?
(OsmApiException, OsmApiReadResponseException and OsmConnectionException)

app/src/main/java/de/westnordost/streetcomplete/MainActivity.kt Outdated Show resolved Hide resolved
.../de/westnordost/streetcomplete/data/osm/edits/upload/changesets/ChangesetAutoCloserWorker.kt Outdated Show resolved Hide resolved
@FloEdelmann FloEdelmann marked this pull request as ready for review April 29, 2021 12:34
westnordost
westnordost requested changes Apr 29, 2021
View reviewed changes
app/src/main/java/de/westnordost/streetcomplete/data/osmnotes/NotesApiImpl.kt Show resolved Hide resolved
app/src/main/java/de/westnordost/streetcomplete/data/osmnotes/NotesApiImpl.kt Outdated Show resolved Hide resolved
app/src/main/java/de/westnordost/streetcomplete/data/osmnotes/NotesApi.kt Show resolved Hide resolved
app/src/main/java/de/westnordost/streetcomplete/data/osm/mapdata/MapDataApiImpl.kt Outdated Show resolved Hide resolved
app/src/main/java/de/westnordost/streetcomplete/data/osm/mapdata/MapDataApiImpl.kt Show resolved Hide resolved
app/src/main/java/de/westnordost/streetcomplete/data/osm/mapdata/MapDataApi.kt Show resolved Hide resolved
app/src/main/java/de/westnordost/streetcomplete/data/upload/QueryTooBigException.kt Outdated Show resolved Hide resolved
app/src/main/java/de/westnordost/streetcomplete/MainActivity.kt Outdated Show resolved Hide resolved
@westnordost
Copy link
Member

Two thoughts:

  • catching "all" is not viable because f.e. IllegalArgumentException should not be caught
  • Actually, this proposed tryConnect function could maybe even do all/most of the wrapping, f.e. for the authorization exception, so then this will be very little boilerplate code.

@FloEdelmann FloEdelmann marked this pull request as draft May 2, 2021 14:21
@FloEdelmann FloEdelmann marked this pull request as ready for review May 2, 2021 16:24
@westnordost
Copy link
Member

Looks good!

@westnordost
Copy link
Member

I'll merge it right away. And then, with that done, I think I can also release a public alpha version to get some more error reports before launching it as beta in the play store.

@westnordost westnordost merged commit cec42fd into streetcomplete:master May 2, 2021
@FloEdelmann FloEdelmann deleted the pure-kotlin-exceptions branch May 2, 2021 18:39
@westnordost westnordost mentioned this pull request Dec 20, 2023
Closed
@FloEdelmann FloEdelmann self-assigned this Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westnordost westnordost westnordost approved these changes

Assignees

@FloEdelmann FloEdelmann

Labels
None yet
Projects
iOS Port
Status: Released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[v32] Define/wrap exceptions thrown by MapDataApi and NotesApi in Kotlin
2 participants
@FloEdelmann @westnordost