-
-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap some osmapi exceptions in Kotlin exceptions #2821
Wrap some osmapi exceptions in Kotlin exceptions #2821
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What should I do about these few missing ones?
(OsmApiException
, OsmApiReadResponseException
and OsmConnectionException
)
app/src/main/java/de/westnordost/streetcomplete/MainActivity.kt
Outdated
Show resolved
Hide resolved
.../de/westnordost/streetcomplete/data/osm/edits/upload/changesets/ChangesetAutoCloserWorker.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/de/westnordost/streetcomplete/data/osmnotes/NotesApiImpl.kt
Show resolved
Hide resolved
app/src/main/java/de/westnordost/streetcomplete/data/osmnotes/NotesApiImpl.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/de/westnordost/streetcomplete/data/osmnotes/NotesApi.kt
Show resolved
Hide resolved
app/src/main/java/de/westnordost/streetcomplete/data/osm/mapdata/MapDataApiImpl.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/de/westnordost/streetcomplete/data/osm/mapdata/MapDataApiImpl.kt
Show resolved
Hide resolved
app/src/main/java/de/westnordost/streetcomplete/data/osm/mapdata/MapDataApi.kt
Show resolved
Hide resolved
app/src/main/java/de/westnordost/streetcomplete/data/upload/QueryTooBigException.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/de/westnordost/streetcomplete/MainActivity.kt
Outdated
Show resolved
Hide resolved
Two thoughts:
|
* AuthorizationException * ConflictException * QueryTooBigException
Looks good! |
I'll merge it right away. And then, with that done, I think I can also release a public alpha version to get some more error reports before launching it as beta in the play store. |
Closes #2818.