-
-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make changes for when the minSdk is set to 21. #2031
Make changes for when the minSdk is set to 21. #2031
Conversation
Note that I will probably not review this for some time. Here is some more things that could be changed:
|
app/src/main/java/de/westnordost/streetcomplete/controls/QuestDownloadProgressFragment.kt
Outdated
Show resolved
Hide resolved
0c710ec
to
120f4c2
Compare
app/src/main/java/de/westnordost/streetcomplete/user/QuestStatisticsByQuestTypeFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/de/westnordost/streetcomplete/user/QuestStatisticsByQuestTypeFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/de/westnordost/streetcomplete/quests/localized_name/AddRoadNameForm.kt
Outdated
Show resolved
Hide resolved
...src/main/java/de/westnordost/streetcomplete/quests/localized_name/AddLocalizedNameAdapter.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/de/westnordost/streetcomplete/location/LocationUtil.java
Outdated
Show resolved
Hide resolved
120f4c2
to
f6f1fbb
Compare
...src/main/java/de/westnordost/streetcomplete/quests/localized_name/AddLocalizedNameAdapter.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/de/westnordost/streetcomplete/quests/localized_name/AddRoadNameForm.kt
Outdated
Show resolved
Hide resolved
b816b26
to
1678117
Compare
1678117
to
25f1019
Compare
Another thing that comes to my mind would be that in pre-Lollipop, referencing colors in vector drawables is not (really) possible. For many icons, there is a day and a night variant because of this. If the min-sdk is lollipop, instead the drawable can reference a color instead, so the drawables don't need to be duplicated. Example |
Sorry for the late reply. I'll make the change, thanks! So what's the color value that should be used? Or should a new one be created? |
25f1019
to
1ed6a30
Compare
I think a color value does not exist for it yet, as this is just one of many colors used in the vector drawables. No issue with the late reply. After all, this PR is going to be around for a while, maybe 2 more months. And even if you abandoned this PR now, it still is valuable for the project because then later I can finish it when finally the minsdk is set to 21. |
5138e6a
to
5dcc65e
Compare
5dcc65e
to
5c42c1c
Compare
5c42c1c
to
f7de30b
Compare
Sorry, my original plan was to up the min sdk version end last year because I intended to couple that with the change to add "measurement with AR"-feature (and thus requiring camera permission). That feature wasn't developed so far after all, so that's why there was no good reason to up the min sdk version yet. So it looks like this is going to lie around a while longer, but I will get back to it eventually. No need to bother fixing the conflicts, I will do that when the time comes. |
Finally, one year late, I decided to finally drop support for Android 4. Thank you for your work so far on it, Isira. Quite a few things have changed in the app since you last brought this PR up to master, so there are some conflicts to solve. I will mark this PR as "help wanted" in case other contributors to this app would like to finish up this PR (that is: solve merge conflict, check if everything still works) unless you are interested in bringing it to completion (again). If noone else will do it, I will finish up this PR, so your work on it will merged anyway and you'll be credited for your work of course. |
# Conflicts: # app/build.gradle.kts # app/src/main/java/de/westnordost/streetcomplete/MainActivity.java # app/src/main/java/de/westnordost/streetcomplete/controls/DownloadProgressFragment.kt # app/src/main/java/de/westnordost/streetcomplete/data/osm/edits/upload/changesets/OpenQuestChangesetsManager.kt # app/src/main/java/de/westnordost/streetcomplete/map/MainFragment.kt # app/src/main/java/de/westnordost/streetcomplete/map/MapFragment.kt # app/src/main/java/de/westnordost/streetcomplete/map/QuestPinLayerManager.kt # app/src/main/java/de/westnordost/streetcomplete/map/TangramPinsSpriteSheet.kt # app/src/main/java/de/westnordost/streetcomplete/notifications/OsmUnreadMessagesFragment.kt # app/src/main/java/de/westnordost/streetcomplete/quests/AbstractBottomSheetFragment.kt # app/src/main/java/de/westnordost/streetcomplete/quests/SplitWayFragment.kt # app/src/main/java/de/westnordost/streetcomplete/quests/max_speed/AddMaxSpeedForm.kt # app/src/main/java/de/westnordost/streetcomplete/settings/ShowQuestFormsActivity.kt # app/src/main/java/de/westnordost/streetcomplete/tutorial/TutorialFragment.kt # app/src/main/java/de/westnordost/streetcomplete/user/CircularFlagView.kt
because that feature was added in SDK 24, so for below that, the android build system will create raster version for those vector graphics
Alright, this is brought up to current master plus all kinds of optimizations done that are only available since v21. Mostly, referencing color values in vector drawables makes it possible to delete all those resources for night. |
The resulting APK's size is 45 MB, so about 30 MB lighter than now. |
No description provided.