This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
Bump pulsar to 2.10.0.0-rc12 and fix testListOffsetForEmptyRolloverLedger #1176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should also migrate the similar change to branch-2.9.2 because apache/pulsar#14664 will also be included in Pulsar 2.9.2. |
Demogorgon314
approved these changes
Mar 14, 2022
BewareMyPower
added a commit
that referenced
this pull request
Mar 14, 2022
…dger (#1176) Fixes #1175 ### Motivation The `ManagedLedger#rollCurrentLedgerIfFull` can only work when the managed ledger's state is `LedgerOpened` since apache/pulsar#14664. The corner case described in #894 is still possible when some entries are sent but not persisted after a rollover and retention works. Therefore, we should still keep the `testListOffsetForEmptyRolloverLedger` to avoid the regression in KoP. ### Modifications - Bump Pulsar to 2.10.0.0-rc12, which includes apache/pulsar#14664 - Change the managed ledger's state to `LedgerOpened` in `testListOffsetForEmptyRolloverLedger`. (cherry picked from commit bb37893)
|
@BewareMyPower Could you please help cherry-pick to branch-2.9.2 |
Demogorgon314
pushed a commit
to Demogorgon314/kop
that referenced
this pull request
Mar 15, 2022
…dger (streamnative#1176) Fixes streamnative#1175 ### Motivation The `ManagedLedger#rollCurrentLedgerIfFull` can only work when the managed ledger's state is `LedgerOpened` since apache/pulsar#14664. The corner case described in streamnative#894 is still possible when some entries are sent but not persisted after a rollover and retention works. Therefore, we should still keep the `testListOffsetForEmptyRolloverLedger` to avoid the regression in KoP. ### Modifications - Bump Pulsar to 2.10.0.0-rc12, which includes apache/pulsar#14664 - Change the managed ledger's state to `LedgerOpened` in `testListOffsetForEmptyRolloverLedger`. (cherry picked from commit bb37893)
1 task
eolivelli
pushed a commit
to eolivelli/kop
that referenced
this pull request
Mar 21, 2022
…dger (streamnative#1176) Fixes streamnative#1175 ### Motivation The `ManagedLedger#rollCurrentLedgerIfFull` can only work when the managed ledger's state is `LedgerOpened` since apache/pulsar#14664. The corner case described in streamnative#894 is still possible when some entries are sent but not persisted after a rollover and retention works. Therefore, we should still keep the `testListOffsetForEmptyRolloverLedger` to avoid the regression in KoP. ### Modifications - Bump Pulsar to 2.10.0.0-rc12, which includes apache/pulsar#14664 - Change the managed ledger's state to `LedgerOpened` in `testListOffsetForEmptyRolloverLedger`.
eolivelli
pushed a commit
to eolivelli/kop
that referenced
this pull request
Mar 21, 2022
…dger (streamnative#1176) Fixes streamnative#1175 ### Motivation The `ManagedLedger#rollCurrentLedgerIfFull` can only work when the managed ledger's state is `LedgerOpened` since apache/pulsar#14664. The corner case described in streamnative#894 is still possible when some entries are sent but not persisted after a rollover and retention works. Therefore, we should still keep the `testListOffsetForEmptyRolloverLedger` to avoid the regression in KoP. ### Modifications - Bump Pulsar to 2.10.0.0-rc12, which includes apache/pulsar#14664 - Change the managed ledger's state to `LedgerOpened` in `testListOffsetForEmptyRolloverLedger`.
michaeljmarshall
pushed a commit
to michaeljmarshall/kop
that referenced
this pull request
Dec 13, 2022
…dger (streamnative#1176) Fixes streamnative#1175 The `ManagedLedger#rollCurrentLedgerIfFull` can only work when the managed ledger's state is `LedgerOpened` since apache/pulsar#14664. The corner case described in streamnative#894 is still possible when some entries are sent but not persisted after a rollover and retention works. Therefore, we should still keep the `testListOffsetForEmptyRolloverLedger` to avoid the regression in KoP. - Bump Pulsar to 2.10.0.0-rc12, which includes apache/pulsar#14664 - Change the managed ledger's state to `LedgerOpened` in `testListOffsetForEmptyRolloverLedger`. (cherry picked from commit bb37893)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1175
Motivation
The
ManagedLedger#rollCurrentLedgerIfFullcan only work when the managed ledger's state isLedgerOpenedsince apache/pulsar#14664. The corner case described in #894 is still possible when some entries are sent but not persisted after a rollover and retention works. Therefore, we should still keep thetestListOffsetForEmptyRolloverLedgerto avoid the regression in KoP.Modifications
LedgerOpenedintestListOffsetForEmptyRolloverLedger.Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)